Add missing definitions and fix pictureTag arguments#278
Merged
Conversation
strausr
approved these changes
Dec 14, 2021
patrick-tolosa
approved these changes
Dec 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
What does this PR address?
[x] Gitub issue #189
[ ] Refactoring
[ ] New feature
[x] Bug fix
[x] Adds more tests
Are tests included?
[x] Yes
[ ] No
Reviewer, Please Note:
Unit tests are added to make sure the backward compatibility is not broken by adding new cld.pictureTag parameter