fix(browse): disambiguate numeric short SHAs from issue/PR numbers#12684
Open
fix(browse): disambiguate numeric short SHAs from issue/PR numbers#12684
Conversation
… refs When a selector arg is both numeric and commit-like, browse now validates whether it resolves to a commit in the target repo before defaulting to an issue URL. This fixes cases like decimal-only short SHAs being interpreted as issue numbers. Add tests for both commit-found and commit-not-found paths.
amirHdev
temporarily deployed
to
cli-automation
GitHub Actions
Inactive
cliAutomation
added
the
external
|
Thank you for your pull request! 🎉 This PR appears to fix the following issues that are not labeled with
help wanted
As outlined in our Contributing Guidelines, we expect that PRs are only created for issues that have been labeled While we appreciate your initiative, please note that:
What happens next:
Thank you for your understanding and contribution to the project! 🙏 This comment was automatically generated by cliAutomation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
gh browseselector disambiguation for numeric-only short SHAs.Today, if the selector arg is numeric (e.g.
309628980),gh browsetreats it as an issue/PR number before considering commit refs. This causes decimal-only short SHAs to resolve toissues/<n>instead ofcommit/<sha>.This change updates
browseto disambiguate in the ambiguous case:Changes
parseSectioninpkg/cmd/browse/browse.goto validate ambiguous numeric+commit-like selectors via API.commitRefExistshelper that calls:GET /repos/{owner}/{repo}/commits/{ref}404/422as “commit not found”pkg/cmd/browse/browse_test.gofor:Testing
go test ./pkg/cmd/browseTest_runBrowsefor ambiguous numeric selectors.Fixes #12357