Skip to content

Commit aa356b0

Browse files
committed
updated deploy.sh
1 parent da1856d commit aa356b0

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

gcp_cloud_function_sql_export/deploy.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ gcloud functions deploy "$name" --trigger-topic "$topic" \
3636
--service-account "$service_account" \
3737
--region "$region" \
3838
--timeout 60 \
39-
--memory 128MB \
40-
--max-instances 1 # this isn't good enough because it sets off an async API call, so successive calls can fail if called before that SQL Admin API export has finished
39+
--memory 128MB
40+
# may want multiple concurrent calls to different SQL instances at the same time
41+
#
42+
# also doesn't prevent:
43+
#
44+
# "Operation failed because another operation was already in progress."
45+
#
46+
#--max-instances 1 # this isn't good enough because it sets off an async API call, so successive calls can fail if called before that SQL Admin API export has finished
47+
4148
# --vpc-connector "$vpc_connector"

0 commit comments

Comments
 (0)