updated deploy.sh

HariSekhon · HariSekhon · commit aa356b05526d · 2020-10-21T09:51:54.000+01:00
diff --git a/gcp_cloud_function_sql_export/deploy.sh b/gcp_cloud_function_sql_export/deploy.sh
@@ -36,6 +36,13 @@ gcloud functions deploy "$name" --trigger-topic "$topic" \
                                 --service-account "$service_account" \
                                 --region "$region" \
                                 --timeout 60 \
-                                --memory 128MB \
-                                --max-instances 1  # this isn't good enough because it sets off an async API call, so successive calls can fail if called before that SQL Admin API export has finished
+                                --memory 128MB
+                                # may want multiple concurrent calls to different SQL instances at the same time
+                                #
+                                # also doesn't prevent:
+                                #
+                                # "Operation failed because another operation was already in progress."
+                                #
+                                #--max-instances 1  # this isn't good enough because it sets off an async API call, so successive calls can fail if called before that SQL Admin API export has finished
+
                                 # --vpc-connector "$vpc_connector"
