Added uncurse() function #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks interesting. @adamestein Rebase your PR and update for master's changes |
Author
|
Unfortunately, I am not overly versed in Git. If you mention what I
need to do to rebase and update, I can do that.
On Tue, 2019-11-19 at 12:08 -0800, Alex wrote:
This looks interesting. @adamestein Rebase your PR and update for
master's changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#17?email_so
urce=notifications\u0026email_token=ABGNEZ4J7QHUYF4553I2IHLQURBU5A5CN
FSM4BZJMZDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZ
GOEEPSNPQ#issuecomment-555689662",
"url": "#17?email_sourc
e=notifications\u0026email_token=ABGNEZ4J7QHUYF4553I2IHLQURBU5A5CNFSM
4BZJMZDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE
EPSNPQ#issuecomment-555689662",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
--
Adam ([email protected])
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas reverse() removed the specified attribute, uncurse() will restore the previous value (assuming there was one). If the attribute is new (rather than overwritten), it is simply deleted just as reverse() would do (since there was no previous value to go back to).
Also added unit tests, updated README, and updated version number.
This came out of the need to restore datetime.now() since I'm running many unit tests and the one test that 'cursed' datetime.now() affects any unit tests running after that use that method. reverse() simply deleted now() so it didn't exist anymore. Needed it restored back to the original function.