[CIVIS-9315] Fix apt-get and update AWS CLI#97
Merged
Conversation
dd00ad1 to
3242c2e
Compare
3242c2e to
2e95c6f
Compare
2e95c6f to
23e594e
Compare
mheilman
commented
Aug 26, 2024
| @@ -1,6 +1,13 @@ | |||
| FROM python:3.12.4-slim AS production | |||
| ARG PLATFORM=linux/x86_64 | |||
| ARG BASE_IMAGE=python:3.12.5-slim | |||
Contributor
Author
There was a problem hiding this comment.
Just moving from python:3.12.4-slim to python:3.12.5-slim fixed the issue with running apt-get in FIPS-mode. Apparently, python:3.12.4-slim was last built before the issue was fixed.
mheilman
commented
Aug 26, 2024
| curl && \ | ||
| curl \ | ||
| mandoc # For AWS CLI help \ | ||
| unzip && \ |
Contributor
Author
There was a problem hiding this comment.
unzip is needed for the aws CLI, but it seems generally useful and isn't a big dependency.
mheilman
commented
Aug 26, 2024
| @@ -0,0 +1,19 @@ | |||
| version: 0.2 | |||
Contributor
Author
There was a problem hiding this comment.
I added this to make things easier to test.
b239191 to
3e69465
Compare
3e69465 to
01e5f4f
Compare
|
Pull Request Merged!!! This build is running now. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
apt-getby updating the base image.Also:
generate-requirements-full.shrun in a docker container to ensure the environment matches.Here's a test job in Platform.
CHANGELOG.mdat the repo's root level