improved examples; refactor(advanced list): removed unnecessary empty state view parameter from initializer

crelies · crelies · commit 6cb83434d1d0 · 2022-03-30T23:23:37.000+02:00
diff --git a/Example/Shared/Views/ContentExampleView.swift b/Example/Shared/Views/ContentExampleView.swift
@@ -16,8 +16,6 @@ struct ContentExampleView: View {
                 Text("Example 1")
                 Text("Example 2")
                 Text("Example 3")
-            } emptyStateView: {
-                Text("Empty")
             } errorStateView: { error in
                 VStack(alignment: .leading) {
                     Text("Error").foregroundColor(.primary)
diff --git a/Example/Shared/Views/DataExampleView.swift b/Example/Shared/Views/DataExampleView.swift
@@ -93,10 +93,10 @@ struct DataExampleView: View {
                 .refreshable {
                     listState = .loading
 
-                    let duration = UInt64(1.5 * 1_000_000_000)
-                    try? await Task<Never, Never>.sleep(nanoseconds: duration)
-
                     Task(priority: .userInitiated) {
+                        let duration = UInt64(1.5 * 1_000_000_000)
+                        try? await Task<Never, Never>.sleep(nanoseconds: duration)
+
                         let items = ExampleDataProvider.randomItems()
                         self.items.removeAll()
                         self.items.append(contentsOf: items)
diff --git a/Sources/AdvancedList/public/Views/AdvancedList.swift b/Sources/AdvancedList/public/Views/AdvancedList.swift
@@ -81,11 +81,19 @@ extension AdvancedList {
 @available(iOS 15, *)
 @available(macOS 12, *)
 @available(tvOS 15, *)
-extension AdvancedList {
-    public init<Content: View>(listState: ListState, @ViewBuilder content: @escaping () -> Content, @ViewBuilder emptyStateView: @escaping () -> EmptyStateView, @ViewBuilder errorStateView: @escaping (Error) -> ErrorStateView, @ViewBuilder loadingStateView: @escaping () -> LoadingStateView) {
+extension AdvancedList where EmptyStateView == EmptyView {
+    /// Initializes the list with the given content.
+    /// Uses the native `SwiftUI` `List` as list view.
+    ///
+    /// - Parameters:
+    ///   - listState: A value representing the state of the list.
+    ///   - content: A view builder that creates the content of the list.
+    ///   - errorStateView: A view builder that creates the view for the error state of the list.
+    ///   - loadingStateView: A view builder that creates the view for the loading state of the list.
+    public init<Content: View>(listState: ListState, @ViewBuilder content: @escaping () -> Content, @ViewBuilder errorStateView: @escaping (Error) -> ErrorStateView, @ViewBuilder loadingStateView: @escaping () -> LoadingStateView) {
         self.type = .init(type: AdvancedListType<Never>.container(content: { AnyView(List(content: content)) }))
         self.listState = listState
-        self.emptyStateView = emptyStateView
+        self.emptyStateView = { EmptyStateView() }
         self.errorStateView = errorStateView
         self.loadingStateView = loadingStateView
         configurations = []
