-
Notifications
You must be signed in to change notification settings - Fork 931
(#3668) Add choco support command #3676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/chocolatey/infrastructure.app/commands/ChocolateySupportCommand.cs
Outdated
Show resolved
Hide resolved
AdmiringWorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions regarding the message output.
c6bcc7d to
262e0d8
Compare
AdmiringWorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
corbob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. I'll leave it to @AdmiringWorm or @gep13 to merge as I can't see the Test Kitchen runs to verify they all worked.
This commit introduces a new choco support command for Chocolatey CLI. This command already exists for Chocolatey Licensed Extension, but the decision was made to also introduce it into open-source, for consistency reasons. The output from this version of the command is different to what is shown when you have a license in play, as it points the user to the open-source resources, rather than to reach out to the support team. Also included is some unit tests and some pester tests, to ensure that the command is working as expected.
|
Since everyone have approved this PR now, and the changes still looks good to me, I will get this PR merged now. |
Description Of Changes
This commit introduces a new choco support command for Chocolatey CLI. This command already exists for Chocolatey Licensed Extension, but the decision was made to also introduce it into open-source, for consistency reasons. The output from this version of the command is different to what is shown when you have a license in play, as it points the user to the open-source resources, rather than to reach out to the support team.
Also included is some unit tests and some pester tests, to ensure that the command is working as expected.
Motivation and Context
After discussion with the support team, having the
choco supportcommand in both CLI and CLE makes a lot of sense, and will help people find the help that they need.Testing
choco supportand verify the outputchoco support -hand verify the outputchoco -hand see the support command listedOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3668