htmlreport: Few style fixes

JIghtuse · JIghtuse · commit e4f81ba755fc · 2016-03-11T11:12:52.000+06:00
* Fix wrong indentation
* Use single quotes for consistency
* It is fine to substitute %s with empty str
diff --git a/htmlreport/cppcheck-htmlreport b/htmlreport/cppcheck-htmlreport
@@ -590,27 +590,20 @@ if __name__ == '__main__':
                     if error['severity'] == 'error':
                         error_class = 'class="error"'
                     if error['id'] == 'missingInclude':
-                            output_file.write(
-                                '\n         <tr><td></td><td>%s</td><td></td><td>%s</td><td>%s</td></tr>' %
-                                (error['id'], error['severity'], error['msg']))
+                        output_file.write(
+                            '\n         <tr><td></td><td>%s</td><td></td><td>%s</td><td>%s</td></tr>' %
+                            (error['id'], error['severity'], error['msg']))
                     elif (error['id'] == 'unmatchedSuppression') and filename.endswith('*'):
                         output_file.write(
-                            "\n         <tr><td></td><td>%s</td><td></td><td>%s</td><td %s>%s</td></tr>" %
+                            '\n         <tr><td></td><td>%s</td><td></td><td>%s</td><td %s>%s</td></tr>' %
                             (error['id'], error['severity'], error_class,
                              error['msg']))
                     else:
-                        if cwe_url:
-                            output_file.write(
-                                "\n       <tr><td><a href='%s#line-%d'>%d</a></td><td>%s</td><td>%s</td><td>%s</td><td %s>%s</td></tr>" %
-                                (data['htmlfile'], error['line'], error['line'],
-                                 error['id'], cwe_url, error['severity'], error_class,
-                                 error['msg']))
-                        else:
-                            output_file.write(
-                                "\n       <tr><td><a href='%s#line-%d'>%d</a></td><td>%s</td><td></td><td>%s</td><td %s>%s</td></tr>" %
-                                (data['htmlfile'], error['line'], error['line'],
-                                 error['id'], error['severity'], error_class,
-                                 error['msg']))
+                        output_file.write(
+                            '\n       <tr><td><a href="%s#line-%d">%d</a></td><td>%s</td><td>%s</td><td>%s</td><td %s>%s</td></tr>' %
+                            (data['htmlfile'], error['line'], error['line'],
+                             error['id'], cwe_url, error['severity'], error_class,
+                             error['msg']))
 
         output_file.write('\n       </table>')
         output_file.write(HTML_FOOTER % contentHandler.versionCppcheck)
