mgr/cephadm: track SMB rgw_creds_uri as a daemon dependency#69932
Draft
avanthakkar wants to merge 2 commits into
Draft
mgr/cephadm: track SMB rgw_creds_uri as a daemon dependency#69932avanthakkar wants to merge 2 commits into
avanthakkar wants to merge 2 commits into
Conversation
Implement intelligent action selection for SMB daemon updates by tracking feature changes as dependencies. When SMB service features change (e.g., adding cephfs-proxy, remote-control, keybridge), the system now triggers a REDEPLOY instead of RECONFIG, as these changes require container structure modifications. Fixes: https://tracker.ceph.com/issues/77762 Signed-off-by: Shweta Sodani <[email protected]>
Add rgw_creds_uri as a Dep.FIELD in get_dependencies and include it in needs_redeploy_prefixes so a change triggers REDEPLOY. Also fix _save_pending_rgw_config to use cred_map.get() instead of a bare dict lookup. Fixes: https://tracker.ceph.com/issues/77763 Signed-off-by: Avan Thakkar <[email protected]>
avanthakkar
force-pushed
the
add-smb-rgw-creds-uri-deps
branch
from
76cb5d4 to
b960d6c
Compare
14 tasks
avanthakkar
force-pushed
the
add-smb-rgw-creds-uri-deps
branch
from
5ae54a5 to
b960d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #69907
When an RGW share is added to a cluster that already has CephFS shares, RGW credentials show as empty in
net conf listinside the container. The private-store URI carrying credentials is appended toSAMBACC_CONFIGviaextra_config_uris, but was not tracked as a dependency for cephadm to redeploy the daemon. Thusupdate-config --watchsidecarcontinues running with the stale
SAMBACC_CONFIGand never receives the RGW credentials URI.The PR intends to fix this issue by adding
rgw_creds_urias a dependency and include it in REDEPLOY action too.Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.