Skip to content

mgr/smb: add fruit:nfs_aces=no for macOS compatibility mode#69930

Merged
phlogistonjohn merged 1 commit into
mainfrom
Add-more-mac-configs
Jul 9, 2026
Merged

mgr/smb: add fruit:nfs_aces=no for macOS compatibility mode#69930
phlogistonjohn merged 1 commit into
mainfrom
Add-more-mac-configs

Conversation

@Shwetha-Acharya

@Shwetha-Acharya Shwetha-Acharya commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

When macOS client compatibility is enabled, add the global Samba configuration option 'fruit:nfs_aces = no' to disable NFS ACE handling in the fruit VFS module. This improves compatibility with macOS SMB clients by preventing conflicts between NFS-style ACLs and macOS extended attributes.

The configuration is automatically applied when:

  • Creating a new cluster with --client-compat=macos
  • Updating an existing cluster to macOS mode

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@Shwetha-Acharya Shwetha-Acharya requested review from a team as code owners July 3, 2026 10:18
@github-actions github-actions Bot added the pybind label Jul 3, 2026
@Shwetha-Acharya Shwetha-Acharya marked this pull request as draft July 3, 2026 10:19
@Sodani

Sodani commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Current changes LGTM , i see this PR is still in draft.

@Shwetha-Acharya

Shwetha-Acharya commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current changes LGTM , i see this PR is still in draft.

@Sodani I kept this PR in draft while waiting to see if QA testing uncovers any additional essential parameters. I'll mostly wait until the end of today, and if nothing else comes up, I'll move forward with just these options.

@Shwetha-Acharya Shwetha-Acharya marked this pull request as ready for review July 7, 2026 11:55
avanthakkar
avanthakkar approved these changes Jul 7, 2026
View reviewed changes

@avanthakkar avanthakkar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anoopcs9
anoopcs9 reviewed Jul 8, 2026
View reviewed changes

@anoopcs9 anoopcs9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

I also wonder if we should make a note somewhere explaining the rationale behind this new module specific global option, so it can be revisited later - possibly to remove it at a later stage.

@Shwetha-Acharya
mgr/smb: add fruit:nfs_aces=no for macOS compatibility mode
d5b7307 
When macOS client compatibility is enabled, add the global Samba
configuration option 'fruit:nfs_aces = no' to disable NFS ACE
handling in the fruit VFS module. This improves compatibility
with macOS SMB clients by preventing conflicts between NFS-style
ACLs and macOS extended attributes.

The configuration is automatically applied when:
- Creating a new cluster with --client-compat=macos
- Updating an existing cluster to macOS mode

Signed-off-by: Shwetha K Acharya <[email protected]>
@Shwetha-Acharya

Shwetha-Acharya commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

I also wonder if we should make a note somewhere explaining the rationale behind this new module specific global option, so it can be revisited later - possibly to remove it at a later stage.

I have created a ceph tracker explaining the rationale and linked the same in the comment before adding fruit:nfs_aces=no @anoopcs9

anoopcs9
anoopcs9 approved these changes Jul 8, 2026
View reviewed changes

@anoopcs9 anoopcs9 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder if we should make a note somewhere explaining the rationale behind this new module specific global option, so it can be revisited later - possibly to remove it at a later stage.

I have created a ceph tracker explaining the rationale and linked the same in the comment before adding fruit:nfs_aces=no @anoopcs9

Thank you for creating the tracker.

@anoopcs9 anoopcs9 requested a review from phlogistonjohn July 8, 2026 13:35
phlogistonjohn
phlogistonjohn approved these changes Jul 8, 2026
View reviewed changes

@phlogistonjohn phlogistonjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avanthakkar

avanthakkar commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

jenkins test api

@avanthakkar

avanthakkar commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Teuthology run scheduled: https://pulpito-ng.ceph.com/avan-2026-07-09_06:12:17-orch:cephadm:smb-wip-athakkar-testing-2026-07-07-1920-distro-default-trial

@avanthakkar

avanthakkar commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Teuthology run scheduled: https://pulpito-ng.ceph.com/avan-2026-07-09_06:12:17-orch:cephadm:smb-wip-athakkar-testing-2026-07-07-1920-distro-default-trial

I see 3 failures of which 1 is already a known flake and the other two doesn't seem related to this PR atleast

@Shwetha-Acharya

Shwetha-Acharya commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@phlogistonjohn The existing teuthology failures look urelated to me as well. Please check if this PR can be merged.

@phlogistonjohn

phlogistonjohn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Build: https://jenkins.ceph.com/job/ceph-dev-pipeline/7047/
Including: https://github.com/ceph/ceph/issues?q=state%3Aopen%20label%3Awip-phlogistonjohn-testing-1

@phlogistonjohn

phlogistonjohn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Teuthology Run: https://pulpito-ng.ceph.com/runs/phlogistonjohn-2026-07-09_21:50:32-orch-wip-phlogistonjohn-testing-1-2026-07-09-1415-distro-default-trial
(6) failures out of 64 tests.
4 well-known flakes for ctdb_status
1 failure to connect to AD
1 failure to connect to share

Teuthology Re-run: https://pulpito-ng.ceph.com/runs/phlogistonjohn-2026-07-09_23:10:58-orch-wip-phlogistonjohn-testing-1-2026-07-09-1415-distro-default-trial
3 failures out of 6 re-run tests.
All repeat failures were the well-known flakes for ctdb_status

@phlogistonjohn phlogistonjohn merged commit 228c85a into main Jul 9, 2026
24 checks passed
@phlogistonjohn phlogistonjohn deleted the Add-more-mac-configs branch July 9, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes
@avanthakkar avanthakkar avanthakkar approved these changes
@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

pybind wip-athakkar-testing wip-phlogistonjohn-testing-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Shwetha-Acharya @Sodani @avanthakkar @phlogistonjohn @anoopcs9