Storing PdbCode in BioAssemblyIdentifier cannonical representation

sbliven · sbliven · commit 4bba30b3d39d · 2016-06-13T16:25:41.000+02:00
If one tries to load the structure via it's cannonical form, the non-null pdb code
could result in reducing it down to the asymmetric unit. This is acceptable.
diff --git a/biojava-structure/src/main/java/org/biojava/nbio/structure/BioAssemblyIdentifier.java b/biojava-structure/src/main/java/org/biojava/nbio/structure/BioAssemblyIdentifier.java
@@ -72,8 +72,7 @@ public Structure loadStructure(AtomCache cache) throws StructureException,
 
 	@Override
 	public SubstructureIdentifier toCanonical() throws StructureException {
-		// null pdbCode indicates that the structure can't be loaded by AtomCache
-		return new SubstructureIdentifier(null, new ArrayList<ResidueRange>());
+		return new SubstructureIdentifier(pdbCode, new ArrayList<ResidueRange>());
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,7 @@ public Structure loadStructure(AtomCache cache) throws StructureException,`
`72`	`72`
`73`	`73`	`@Override`
`74`	`74`	`public SubstructureIdentifier toCanonical() throws StructureException {`
`75`		`- // null pdbCode indicates that the structure can't be loaded by AtomCache`
`76`		`- return new SubstructureIdentifier(null, new ArrayList<ResidueRange>());`
	`75`	`+ return new SubstructureIdentifier(pdbCode, new ArrayList<ResidueRange>());`
`77`	`76`	`}`
`78`	`77`
`79`	`78`	`@Override`