Skip to content

refactor: remove unused code#540

Merged
mdjastrzebski merged 1 commit into
mainfrom
refactor/remove-unused-code
Oct 28, 2024
Merged

refactor: remove unused code#540
mdjastrzebski merged 1 commit into
mainfrom
refactor/remove-unused-code

Conversation

@mdjastrzebski

@mdjastrzebski mdjastrzebski commented Oct 28, 2024

Copy link
Copy Markdown
Member

Summary

Test plan

@changeset-bot

changeset-bot Bot commented Oct 28, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 699d19f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

Performance Comparison Report

  • Current: HEAD (adf9f57) - 2024-10-28 08:27:56Z
  • Baseline: main (20f5746) - 2024-10-28 08:27:11Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 84.1 ms → 83.0 ms (-1.1 ms, -1.3%) 7 → 7
fib 30 function 38.5 ms → 38.4 ms (-0.1 ms, ±0.0%) 1 → 1
fib 31 function 62.1 ms → 62.3 ms (+0.1 ms, ±0.0%) 1 → 1
fib 32 function 101.2 ms → 100.5 ms (-0.6 ms, -0.6%) 1 → 1
InitialRenders 1 render 1.1 ms → 1.1 ms (-0.0 ms, -0.8%) 2 → 2
InitialRenders 3 render 1.2 ms → 1.2 ms (+0.0 ms, ±0.0%) 4 → 4
ManyRenderIssues render 1.4 ms → 1.4 ms (-0.0 ms, ±0.0%) 5 → 5
Other Component render 52.5 ms → 51.7 ms (-0.8 ms, -1.5%) 4 → 4
Other Component 20 run render 52.4 ms → 52.0 ms (-0.4 ms, -0.7%) 4 → 4
RedundantUpdates render 0.9 ms → 0.9 ms (+0.0 ms, +1.3%) 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 84.1 ms
Stdev: 0.4 ms (0.5%)
Runs: 83.7 84.6 84.9 83.5 84.5 83.7 84.1 84.1 83.9 84.2
Warmup runs: 87.4

Current
Mean: 83.0 ms
Stdev: 0.5 ms (0.6%)
Runs: 82.6 83.8 83.9 82.6 83.3 83.0 82.9 82.6 82.6 82.5
Warmup runs: 96.0		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.5 ms
Stdev: 0.1 ms (0.2%)
Runs: 38.5 38.5 38.5 38.7 38.6 38.5 38.4 38.4 38.4 38.4
Warmup runs: 39.4

Current
Mean: 38.4 ms
Stdev: 0.0 ms (0.1%)
Runs: 38.4 38.4 38.4 38.4 38.4 38.4 38.3 38.5 38.4 38.4
Warmup runs: 39.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.1 ms
Stdev: 0.0 ms (0.1%)
Runs: 62.1 62.1 62.1 62.2 62.2 62.1 62.1 62.2 62.2 62.1
Warmup runs: 62.3

Current
Mean: 62.3 ms
Stdev: 0.4 ms (0.6%)
Runs: 62.0 62.2 62.1 62.1 62.1 62.1 62.3 62.4 62.1 63.3
Warmup runs: 62.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 101.2 ms
Stdev: 0.6 ms (0.6%)
Runs: 101.1 100.8 100.9 100.8 101.0 100.9 100.8 101.0 101.5 102.8
Warmup runs: 103.8

Current
Mean: 100.5 ms
Stdev: 0.1 ms (0.1%)
Runs: 100.5 100.5 100.4 100.5 100.5 100.4 100.8 100.6 100.5 100.5
Warmup runs: 100.5		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.1 ms
Stdev: 0.2 ms (19.3%)
Runs: 1.5 1.4 1.1 1.2 1.2 0.8 1.1 1.1 0.9 1.0
Warmup runs: 131.5

Current
Mean: 1.1 ms
Stdev: 0.2 ms (16.2%)
Runs: 1.3 1.3 1.1 1.4 1.1 0.9 1.2 1.1 0.9 1.0
Warmup runs: 9.5		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.2 ms
Stdev: 0.1 ms (4.8%)
Runs: 1.2 1.3 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.3
Warmup runs: 1.2

Current
Mean: 1.2 ms
Stdev: 0.1 ms (4.8%)
Runs: 1.2 1.4 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.3
Warmup runs: 1.2		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.4 ms
Stdev: 0.0 ms (1.6%)
Runs: 1.4 1.4 1.4 1.4 1.4 1.4 1.4 1.4 1.4 1.4
Warmup runs: 1.4

Current
Mean: 1.4 ms
Stdev: 0.0 ms (2.8%)
Runs: 1.4 1.4 1.5 1.4 1.4 1.4 1.4 1.4 1.4 1.4
Warmup runs: 1.4		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Other Component render Baseline
Mean: 52.5 ms
Stdev: 0.3 ms (0.7%)
Runs: 51.8 52.5 52.5 52.4 52.8 52.4 52.7 53.1 52.6 52.2
Warmup runs: 58.5

Current
Mean: 51.7 ms
Stdev: 0.5 ms (0.9%)
Runs: 51.2 51.5 52.3 51.1 52.0 51.5 51.8 51.6 51.4 52.5
Warmup runs: 78.9		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Baseline
Mean: 52.4 ms
Stdev: 0.3 ms (0.5%)
Runs: 52.3 52.3 52.7 53.0 52.9 52.4 52.4 52.5 52.1 52.2 52.4 52.4 52.2 52.5 52.4 52.3 52.0 52.0 52.6 52.0
Warmup runs: 52.5

Current
Mean: 52.0 ms
Stdev: 0.6 ms (1.1%)
Runs: 52.2 52.3 52.3 51.9 53.9 51.6 51.6 51.5 51.9 51.2 52.0 52.2 52.2 51.9 51.9 51.7 52.2 51.5 52.8 51.3
Warmup runs: 52.1		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
RedundantUpdates render Baseline
Mean: 0.9 ms
Stdev: 0.0 ms (5.2%)
Runs: 0.9 0.9 0.8 0.9 0.8 0.8 0.8 0.8 0.9 1.0
Warmup runs: 0.8

Current
Mean: 0.9 ms
Stdev: 0.1 ms (6.0%)
Runs: 0.9 0.8 0.8 0.9 0.8 0.9 0.8 0.9 0.8 1.0
Warmup runs: 1.2		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Other Component 1 🔴 -
Other Component 20 run 1 🔴 -
Async Component 1 🔴 -

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against 699d19f

@mdjastrzebski mdjastrzebski merged commit d69abb3 into main Oct 28, 2024
@mdjastrzebski mdjastrzebski deleted the refactor/remove-unused-code branch October 28, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdjastrzebski