Skip to content

refactor: markdown cleanup#525

Merged
mdjastrzebski merged 7 commits into
mainfrom
refactor/markdown-cleanup
Oct 22, 2024
Merged

refactor: markdown cleanup#525
mdjastrzebski merged 7 commits into
mainfrom
refactor/markdown-cleanup

Conversation

@mdjastrzebski

@mdjastrzebski mdjastrzebski commented Aug 29, 2024

Copy link
Copy Markdown
Member

Summary

Test plan

@changeset-bot

changeset-bot Bot commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6db1c40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance Comparison Report

  • Current: HEAD (2541f82) - 2024-10-22 15:17:56Z
  • Baseline: main (63f1f35) - 2024-10-22 15:17:06Z

Significant Changes To Duration

Show entries
Name Type Duration Count
Async Component render 82.0 ms → 86.7 ms (+4.7 ms, +5.7%) 🔴 7 → 7
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 82.0 ms
Stdev: 1.4 ms (1.7%)
Runs: 81.0 80.6 80.9 84.1 80.9 81.4 81.0 83.2 83.9 83.4
Warmup runs: 95.1

Current
Mean: 86.7 ms
Stdev: 1.9 ms (2.2%)
Runs: 83.4 87.9 86.2 85.4 85.0 86.1 88.8 89.9 87.4 86.9
Warmup runs: 88.3		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
fib 30 function 38.4 ms → 38.1 ms (-0.4 ms, -1.0%) 1 → 1
fib 31 function 62.3 ms → 62.2 ms (-0.1 ms, ±0.0%) 1 → 1
fib 32 function 100.5 ms → 101.5 ms (+1.0 ms, +0.9%) 1 → 1
InitialRenders 1 render 0.8 ms → 1.1 ms (+0.3 ms, +33.1%) 🔴 2 → 2
InitialRenders 3 render 1.2 ms → 1.2 ms (+0.1 ms, +5.3%) 4 → 4
ManyRenderIssues render 1.3 ms → 1.4 ms (+0.0 ms, +2.7%) 5 → 5
RedundantUpdates render 0.8 ms → 0.9 ms (+0.1 ms, +9.1%) 2 → 2
Show details
Name Type Duration Count
fib 30 function Baseline
Mean: 38.4 ms
Stdev: 0.1 ms (0.2%)
Runs: 38.4 38.3 38.5 38.4 38.4 38.4 38.5 38.5 38.5 38.5
Warmup runs: 39.2

Current
Mean: 38.1 ms
Stdev: 0.9 ms (2.4%)
Runs: 38.3 38.4 38.4 38.4 38.4 38.3 38.3 38.4 35.4 38.3
Warmup runs: 38.8		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.3 ms
Stdev: 0.5 ms (0.8%)
Runs: 62.2 62.0 62.2 62.1 62.9 63.5 62.0 62.1 62.1 62.0
Warmup runs: 62.3

Current
Mean: 62.2 ms
Stdev: 0.1 ms (0.1%)
Runs: 62.2 62.2 62.3 62.1 62.1 62.1 62.0 62.2 62.1 62.3
Warmup runs: 62.2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 100.5 ms
Stdev: 0.1 ms (0.1%)
Runs: 100.5 100.4 100.5 100.5 100.6 100.4 100.4 100.6 100.4 100.6
Warmup runs: 100.6

Current
Mean: 101.5 ms
Stdev: 3.0 ms (2.9%)
Runs: 100.5 100.4 100.5 100.4 100.4 100.7 100.6 109.9 100.4 100.5
Warmup runs: 100.5		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 0.8 ms
Stdev: 0.0 ms (3.0%)
Runs: 0.9 0.9 0.8 0.9 0.8 0.8 0.8 0.8 0.9 0.8
Warmup runs: 1.7

Current
Mean: 1.1 ms
Stdev: 0.2 ms (16.0%)
Runs: 1.3 1.3 1.1 1.3 1.2 0.9 1.1 1.0 0.9 1.1
Warmup runs: 9.4		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.2 ms
Stdev: 0.0 ms (2.8%)
Runs: 1.2 1.1 1.2 1.1 1.1 1.2 1.2 1.2 1.2 1.2
Warmup runs: 1.1

Current
Mean: 1.2 ms
Stdev: 0.1 ms (6.1%)
Runs: 1.2 1.4 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.3
Warmup runs: 1.3		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.3 ms
Stdev: 0.0 ms (2.5%)
Runs: 1.3 1.3 1.4 1.4 1.3 1.3 1.4 1.4 1.4 1.3
Warmup runs: 1.3

Current
Mean: 1.4 ms
Stdev: 0.0 ms (2.4%)
Runs: 1.4 1.3 1.4 1.4 1.4 1.3 1.4 1.4 1.4 1.4
Warmup runs: 1.3		 Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
RedundantUpdates render Baseline
Mean: 0.8 ms
Stdev: 0.0 ms (3.7%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.9 0.8 0.8 0.8 0.9
Warmup runs: 0.8

Current
Mean: 0.9 ms
Stdev: 0.1 ms (10.0%)
Runs: 0.8 0.8 0.9 0.8 0.9 0.8 0.9 0.9 1.0 1.1
Warmup runs: 0.8		 Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -
Other Component 1 🔴 -
Other Component 20 run 1 🔴 -

Added Entries

Show entries
Name Type Duration Count
Other Component render 52.6 ms 4
Other Component 20 run render 52.9 ms 4
Show details
Name Type Duration Count
Other Component render Current
Mean: 52.6 ms
Stdev: 0.9 ms (1.7%)
Runs: 53.2 51.3 52.0 52.2 53.9 54.0 52.4 53.2 52.1 51.7
Warmup runs: 57.9		 Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Current
Mean: 52.9 ms
Stdev: 0.8 ms (1.4%)
Runs: 52.8 52.5 52.1 52.3 55.8 52.9 52.5 52.4 52.5 52.5 52.6 52.5 52.7 53.1 53.4 53.1 53.0 53.2 52.9 52.9
Warmup runs: 52.4		 Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Removed Entries

Show entries
Name Type Duration Count
Other Component 10 render 52.4 ms 4
Other Component 10 legacy scenario render 51.8 ms 4
Other Component 20 render 52.0 ms 4
Show details
Name Type Duration Count
Other Component 10 render Baseline
Mean: 52.4 ms
Stdev: 0.4 ms (0.8%)
Runs: 52.4 51.8 52.8 52.4 52.1 52.6 52.3 52.9 52.6 51.6
Warmup runs: 241.2		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 10 legacy scenario render Baseline
Mean: 51.8 ms
Stdev: 0.4 ms (0.8%)
Runs: 51.9 51.9 51.8 52.3 52.1 52.2 51.1 51.0 52.0 51.5
Warmup runs: 54.3		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 render Baseline
Mean: 52.0 ms
Stdev: 0.8 ms (1.4%)
Runs: 51.2 51.8 50.8 51.1 51.3 51.8 52.8 52.5 52.8 52.3 53.3 53.4 52.2 52.2 51.4 53.1 51.7 51.7 51.6 51.5
Warmup runs: 52.0		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Generated by 🚫 dangerJS against 6db1c40

@mdjastrzebski mdjastrzebski force-pushed the refactor/markdown-cleanup branch 2 times, most recently from b430416 to 759a5e3 Compare September 28, 2024 14:32
@mdjastrzebski
refactor: use ts-markdown-builder
aac3894 
refactor: prototype disclosure

refactor: replace rest of markdown methods

refactor: workarounds for markdown lib

chore: tweaks

chore: tweaks

chore: tweaks

chore: update markdown builder

chore: tweaks

chore: recreate yarn.lock

refactor: adapt markdown generation
@mdjastrzebski
chore: remove markdown-table dep
ce5ffcb
@mdjastrzebski
refactor: tweaks
28392c4
@mdjastrzebski
chore: test utils
8bddacf
@mdjastrzebski
chore: test warnings
a637827
@mdjastrzebski
refactor: use joinBlocks from markdown builder
af040df
@mdjastrzebski
refactor: hide test code
6db1c40
@mdjastrzebski mdjastrzebski force-pushed the refactor/markdown-cleanup branch from d0dfd2b to 6db1c40 Compare October 22, 2024 15:14
@mdjastrzebski mdjastrzebski merged commit 20f5746 into main Oct 22, 2024
@mdjastrzebski mdjastrzebski deleted the refactor/markdown-cleanup branch October 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdjastrzebski