fix: respect to the "testingLibrary" config option#515
Merged
Conversation
🦋 Changeset detectedLatest commit: 7f737bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mdjastrzebski
approved these changes
Jul 29, 2024
mdjastrzebski
left a comment
mdjastrzebski
left a comment
Member
There was a problem hiding this comment.
Good catch @yusufyildirim! Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I found out that the
testingLibraryoption provided in the config object is not respected in thegetTestingLibraryfunction. The function returns 'react-native' no matter what we provide in the configuration.Looks like the early return statement accidentally removed or forgotten during the v1 effort.
measureRenderInternalsfunction relies ongetTestingLibraryand runs this code forreact-native. It throws an error withreacttesting library, thus this tiny mistake makesreassureunusable withreacttesting library. This PR addresses that issue.Test plan
Provide
reactastestingLibraryconfig optionIdeally, see if it works with
@testing-library/react(I don't think there's a setup for that in the repo)Or, check if
getTestingLibraryandresolveTestingLibraryfunctions resolve properly.