make Mail::ContentDispositionField work with nil value#907
Merged
Conversation
kjg
force-pushed
the
content_disposition_field_parameters
branch
from
48c2590 to
4b668a7
Compare
Contributor
Author
Collaborator
|
Thanks @kjg ! |
jeremy
added a commit
that referenced
this pull request
Sep 16, 2015
make Mail::ContentDispositionField work with nil value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been running into an issue where a content disposition field fails to fully parse due to the filename being in an unspecified encoding. When this happens the ContentDispositionField ends up being crated with a nil value and then when .parameters is called on the field, it raises an error. Instead the parameters should just be empty.