Skip to content

Commit 4312a98

Browse files
authored
test: unflake cookie roundtrip (microsoft#1388)
1 parent f629f91 commit 4312a98

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

playwright/src/test/java/com/microsoft/playwright/TestBrowserContextAddCookies.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@ void shouldWork() {
3838
assertEquals("password=123456", page.evaluate("document.cookie"));
3939
}
4040

41+
// Slightly different rounding on chromium win.
42+
private static List<Cookie> normalizeExpires(List<Cookie> cookies) {
43+
for (Cookie cookie: cookies) {
44+
cookie.expires = (double) Math.round(cookie.expires);
45+
}
46+
return cookies;
47+
}
48+
4149
@Test
4250
void shouldRoundtripCookie() {
4351
page.navigate(server.EMPTY_PAGE);
@@ -53,7 +61,7 @@ void shouldRoundtripCookie() {
5361
context.clearCookies();
5462
assertEquals(0, context.cookies().size());
5563
context.addCookies(cookies);
56-
assertJsonEquals(cookies, context.cookies());
64+
assertJsonEquals(normalizeExpires(cookies), normalizeExpires(context.cookies()));
5765
}
5866

5967
@Test

0 commit comments

Comments
 (0)