Fixed false positive: Member variable not initialized in the constructor with array and (*this) (danmar#5754)

PKEuS · PKEuS · commit 38af865560c8 · 2014-09-29T16:49:20.000+02:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -528,7 +528,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
         }
 
         if (!Token::Match(ftok->next(), "::| %var%") &&
-            !Token::Match(ftok->next(), "this . %var%") &&
+            !Token::Match(ftok->next(), "*| this . %var%") &&
             !Token::Match(ftok->next(), "* %var% =") &&
             !Token::Match(ftok->next(), "( * this ) . %var%"))
             continue;
@@ -700,6 +700,8 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
         // Assignment of array item of member variable?
         else if (Token::Match(ftok, "* %var% =")) {
             assignVar(ftok->next()->str(), scope, usage);
+        } else if (Token::Match(ftok, "* this . %var% =")) {
+            assignVar(ftok->strAt(3), scope, usage);
         }
 
         // The functions 'clear' and 'Clear' are supposed to initialize variable.
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -2171,6 +2171,17 @@ class TestConstructors : public TestFixture {
               "    char name[255];\n"
               "};");
         ASSERT_EQUALS("", errout.str());
+
+        // #5754
+        check("class John\n"
+              "{\n"
+              "public:\n"
+              "    John() {*this->name = '\\0';}\n"
+              "\n"
+              "private:\n"
+              "    char name[255];\n"
+              "};");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void uninitVarArray3() {
