fix: invalid timezone should return err not panic #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Enhanced time zone check 2. modify default NaiveDate value set 1970-01-01 not today
Author
|
Hi @bspeice , Please take some time to review this pr. |
bspeice
requested changes
Sep 3, 2024
| let default_date = default.unwrap_or(&Local::now().naive_local()).date(); | ||
|
|
||
| let default_ts = NaiveDateTime::new(default_date, NaiveTime::from_hms_opt(0, 0, 0).unwrap()); | ||
| // If default is none, 1970-01-01 00:00:00 as default value is better. |
Owner
There was a problem hiding this comment.
dateutil parser specifically uses the current time as a reference, I don't want to change that. Please keep the default as-is.
| let signal = if l[i] == "+" { 1 } else { -1 }; | ||
| let len_li = l[i].len(); | ||
| // check next index's length | ||
| let timezone_len = l[i + 1].len(); |
Owner
There was a problem hiding this comment.
Why change the index here? It changes the meaning of the conditional below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced time zone check
modify default NaiveDate value set 1970-01-01 not today
Fix Issue: #46