Added a space before stdout redirection at browserstack-local call.#14
Open
liubigli wants to merge 1 commit intobrowserstack:masterfrom
Open
Added a space before stdout redirection at browserstack-local call.#14liubigli wants to merge 1 commit intobrowserstack:masterfrom
liubigli wants to merge 1 commit intobrowserstack:masterfrom
Conversation
…n this way it is possible to add custom parameters to the call
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally when we pass to the start function parameters as for example '-parallel-runs', the function add_args append it to the string $call. Before execute the call the stderr to stdout redirection is appended to the string ( see line 121 in Local.php ).
If some custom parameters are passed to the start method, the value of the last custom parameter is sticked with the string "2>&1" in $call variable and this cause an exception.
Adding a space avoid this exception in this case.