Merge pull request docker-java#1061 from tlusk/feature-network-mode

KostyaSha · web-flow · commit 3993c60113d1 · 2018-07-02T19:38:46.000+03:00
Support network mode as part of the docker build
diff --git a/src/main/java/com/github/dockerjava/api/command/BuildImageCmd.java b/src/main/java/com/github/dockerjava/api/command/BuildImageCmd.java
@@ -125,6 +125,12 @@ public interface BuildImageCmd extends AsyncDockerCmd<BuildImageCmd, BuildRespon
     @CheckForNull
     Map<String, String> getLabels();
 
+    /**
+     * @since {@link RemoteApiVersion#VERSION_1_25}
+     */
+    @CheckForNull
+    String getNetworkMode();
+
     // setters
 
     /**
@@ -188,6 +194,11 @@ public interface BuildImageCmd extends AsyncDockerCmd<BuildImageCmd, BuildRespon
     */
     BuildImageCmd withLabels(Map<String, String> labels);
 
+    /**
+     *@since {@link RemoteApiVersion#VERSION_1_25}
+     */
+    BuildImageCmd withNetworkMode(String networkMode);
+
     interface Exec extends DockerCmdAsyncExec<BuildImageCmd, BuildResponseItem> {
     }
 
diff --git a/src/main/java/com/github/dockerjava/core/command/BuildImageCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/BuildImageCmdImpl.java
@@ -66,6 +66,8 @@ public class BuildImageCmdImpl extends AbstrAsyncDockerCmd<BuildImageCmd, BuildR
 
     private Map<String, String> labels;
 
+    private String networkMode;
+
     public BuildImageCmdImpl(BuildImageCmd.Exec exec) {
         super(exec);
     }
@@ -177,6 +179,11 @@ public Map<String, String> getLabels() {
         return labels;
     }
 
+    @Override
+    public String getNetworkMode() {
+        return networkMode;
+    }
+
     // getter lib specific
 
     @Override
@@ -363,6 +370,12 @@ public BuildImageCmd withLabels(Map<String, String> labels) {
         return this;
     }
 
+    @Override
+    public BuildImageCmd withNetworkMode(String networkMode) {
+        this.networkMode = networkMode;
+        return this;
+    }
+
     @Override
     public void close() {
         super.close();
diff --git a/src/main/java/com/github/dockerjava/core/exec/BuildImageCmdExec.java b/src/main/java/com/github/dockerjava/core/exec/BuildImageCmdExec.java
@@ -102,6 +102,10 @@ protected Void execute0(BuildImageCmd command, ResultCallback<BuildResponseItem>
             webTarget = webTarget.queryParamsJsonMap("labels", command.getLabels());
         }
 
+        if (command.getNetworkMode() != null) {
+            webTarget = webTarget.queryParam("networkmode", command.getNetworkMode());
+        }
+
         LOGGER.trace("POST: {}", webTarget);
 
         InvocationBuilder builder = resourceWithOptionalAuthConfig(command, webTarget.request())
diff --git a/src/main/java/com/github/dockerjava/jaxrs/BuildImageCmdExec.java b/src/main/java/com/github/dockerjava/jaxrs/BuildImageCmdExec.java
@@ -121,6 +121,10 @@ protected AbstractCallbackNotifier<BuildResponseItem> callbackNotifier(BuildImag
 
         webTarget = writeMap(webTarget, "labels", command.getLabels());
 
+        if (command.getNetworkMode() != null) {
+            webTarget = webTarget.queryParam("networkmode", command.getNetworkMode());
+        }
+
         webTarget.property(ClientProperties.REQUEST_ENTITY_PROCESSING, RequestEntityProcessing.CHUNKED);
         webTarget.property(ClientProperties.CHUNKED_ENCODING_SIZE, 1024 * 1024);
 

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,10 @@ protected Void execute0(BuildImageCmd command, ResultCallback<BuildResponseItem>`
`102`	`102`	`webTarget = webTarget.queryParamsJsonMap("labels", command.getLabels());`
`103`	`103`	`}`
`104`	`104`
	`105`	`+ if (command.getNetworkMode() != null) {`
	`106`	`+ webTarget = webTarget.queryParam("networkmode", command.getNetworkMode());`
	`107`	`+ }`
	`108`	`+`
`105`	`109`	`LOGGER.trace("POST: {}", webTarget);`
`106`	`110`
`107`	`111`	`InvocationBuilder builder = resourceWithOptionalAuthConfig(command, webTarget.request())`