Report the iso path used by the vm to help debug possible support issues#288
Conversation
cmds.go
Outdated
There was a problem hiding this comment.
Can't you skip the out buffer and send to os.Stdout directly?
There was a problem hiding this comment.
I don't know - I followed the golang.org example..
There was a problem hiding this comment.
json.MarshalIndent is what you're thinking of, I believe: http://golang.org/pkg/encoding/json/#MarshalIndent
(and I agree)
There was a problem hiding this comment.
bizzare - so the docs aren't leading me to best practice >:} (he says throwing stones out the window of his own glass house)
|
OK... Can't research it now... Don't want to hold you up over this. LGTM |
|
Other than @gmlewis's nit, LGTM |
|
So now the question is, do you want to fix it, or do you want me to take over the PR? 😉 |
|
aren't you supposed to be asleep? :p |
SvenDowideit
force-pushed
the
add-iso-path-to-b2d-info
branch
from
88f5578 to
f9ad3ec
Compare
SvenDowideit
force-pushed
the
add-iso-path-to-b2d-info
branch
from
f9ad3ec to
71c52c6
Compare
|
@tianon updated :) |
|
#287 is kinda more important tho |
|
Indeed, I really ought to be asleep. LGTM @gmlewis ? 😄 |
Report the iso path used by the vm to help debug possible support issues
|
Sorry, posthumous LGTM |
3 participants
Follow-on for #287
While testing I was tripped up by the fact that one of my boxes has a
~/.boot2docker/profileI'd forgotten - and without a b2d way to find out what the iso file path really is, we'd have to resort to asking users to tell us (rather than c&p), which is fraught with extra round trips.at the same time, I've formatted the json so its readable.
@tianon @gmlewis