This repository was archived by the owner on Mar 9, 2019. It is now read-only.
db: MinMmapSize is the minimum mmap size in bytes expressed in base 2 #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry for the delay. The Does that work for you? |
Author
|
Yes, actually I fixed the value to 2, and in benchmarks work pretty similar. Thanks |
benbjohnson
added a commit
to benbjohnson/bolt
that referenced
this pull request
May 18, 2015
This commit adjusts the minimum mmap size from 1MB to 32KB. The previous limit was arbitrary and causes wasted space for very small databases. Thanks to @mcuadros for submitting the original pull request: boltdb#351
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #350 says in some cases the optimization to force the minimum file size to 1M is not very useful when your database is very small.
This PR introduce the Option.MinMmapSize param to allow lower sizes