Skip to content

Commit b3f134c

Browse files
Use okhttp3 instead of old one
Change-Id: I1947b256bbc55e907e7faec1bae9d3d50414affd
1 parent 9cec842 commit b3f134c

16 files changed

Lines changed: 43 additions & 41 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
JavaWebsocketClient is library is simple library for Websocket connection in rx for java and Android.
33
It is designed to be fast and fault tolerant.
44

5-
Currently we use okhttp for websocket connection because okhttp is simple and well tested solution.
5+
Currently we use okhttp3 for websocket connection because okhttp3 is simple and well tested solution.
66

77
[![Build Status](https://travis-ci.org/jacek-marchwicki/JavaWebsocketClient.svg?branch=master)](https://travis-ci.org/jacek-marchwicki/JavaWebsocketClient)
88
[![Build Status](https://gitlab-ci.appunite.net/projects/33/status.png?ref=master)](https://gitlab-ci.appunite.net/projects/33?ref=master)
@@ -100,7 +100,7 @@ To run example first run [websocket server](websockets-server/README.md), than u
100100
to your gradle file:
101101

102102
```groovy
103-
compile "com.appunite:websockets-rxjava:3.0.0"
103+
compile "com.appunite:websockets-rxjava:4.0.0"
104104
```
105105
106106
## License

websockets-rxjava-example/src/main/java/com/appunite/socket/MainActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
import com.example.model.MessageType;
3434
import com.google.gson.Gson;
3535
import com.google.gson.GsonBuilder;
36-
import com.squareup.okhttp.OkHttpClient;
37-
import com.squareup.okhttp.Request;
36+
import okhttp3.OkHttpClient;
37+
import okhttp3.Request;
3838

3939
import rx.android.schedulers.AndroidSchedulers;
4040
import rx.android.view.ViewActions;

websockets-rxjava-example/src/test/java/com/example/RxObjectWebSocketsRealTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import com.example.model.MessageType;
2424
import com.google.gson.Gson;
2525
import com.google.gson.GsonBuilder;
26-
import com.squareup.okhttp.OkHttpClient;
27-
import com.squareup.okhttp.Request;
26+
import okhttp3.OkHttpClient;
27+
import okhttp3.Request;
2828

2929
import org.junit.Before;
3030
import org.junit.Ignore;

websockets-rxjava-example/src/test/java/com/example/RxWebSocketsRealTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import com.appunite.websocket.rx.RxWebSockets;
2020
import com.appunite.websocket.rx.messages.RxEvent;
21-
import com.squareup.okhttp.OkHttpClient;
22-
import com.squareup.okhttp.Request;
21+
import okhttp3.OkHttpClient;
22+
import okhttp3.Request;
2323

2424
import org.junit.Before;
2525
import org.junit.Ignore;

websockets-rxjava-example/src/test/java/com/example/SocketRealTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
import com.example.model.MessageType;
2525
import com.google.gson.Gson;
2626
import com.google.gson.GsonBuilder;
27-
import com.squareup.okhttp.OkHttpClient;
28-
import com.squareup.okhttp.Request;
27+
import okhttp3.OkHttpClient;
28+
import okhttp3.Request;
2929

3030
import org.junit.Before;
3131
import org.junit.Ignore;

websockets-rxjava/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ repositories {
1616
}
1717

1818
dependencies {
19-
compile 'com.squareup.okhttp:okhttp-ws:2.5.0'
19+
compile 'com.squareup.okhttp3:okhttp-ws:3.1.1'
2020
compile "io.reactivex:rxjava:1.0.9"
2121
compile "com.google.code.findbugs:jsr305:2.0.1"
2222

@@ -46,7 +46,7 @@ signing {
4646
}
4747
group = "com.appunite"
4848
archivesBaseName = "websockets-rxjava"
49-
version = "3.0.1"
49+
version = "4.0.0"
5050

5151
if (!project.hasProperty("ossrhUsername")) {
5252
project.ext.setProperty("ossrhUsername", null)

websockets-rxjava/src/main/java/com/appunite/websocket/rx/RxMoreObservables.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@
2121
import com.appunite.websocket.rx.object.RxObjectWebSockets;
2222
import com.appunite.websocket.rx.object.messages.RxObjectEventConn;
2323
import com.appunite.websocket.rx.messages.RxEventConn;
24-
import com.squareup.okhttp.ws.WebSocket;
24+
25+
import okhttp3.RequestBody;
26+
import okhttp3.ws.WebSocket;
2527

2628
import java.util.logging.Level;
2729
import java.util.logging.Logger;
2830

2931
import javax.annotation.Nonnull;
3032

31-
import okio.Buffer;
3233
import rx.Observable;
3334
import rx.Observer;
3435
import rx.Subscriber;
@@ -48,7 +49,7 @@ private static Observable<Object> sendMessage(final @Nonnull WebSocket sender, f
4849
public void call(Subscriber<? super Object> subscriber) {
4950
try {
5051
logger.log(Level.FINE, "sendStringMessage: {0}", message);
51-
sender.sendMessage(WebSocket.PayloadType.TEXT, new Buffer().writeUtf8(message));
52+
sender.sendMessage(RequestBody.create(WebSocket.TEXT, message));
5253
subscriber.onNext(new Object());
5354
subscriber.onCompleted();
5455
} catch (Exception e) {

websockets-rxjava/src/main/java/com/appunite/websocket/rx/RxWebSockets.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,20 @@
2323
import com.appunite.websocket.rx.messages.RxEventDisconnected;
2424
import com.appunite.websocket.rx.messages.RxEventPong;
2525
import com.appunite.websocket.rx.messages.RxEventStringMessage;
26-
import com.squareup.okhttp.OkHttpClient;
27-
import com.squareup.okhttp.Request;
28-
import com.squareup.okhttp.Response;
29-
import com.squareup.okhttp.ws.WebSocket;
30-
import com.squareup.okhttp.ws.WebSocketCall;
31-
import com.squareup.okhttp.ws.WebSocketListener;
26+
import okhttp3.OkHttpClient;
27+
import okhttp3.Request;
28+
import okhttp3.Response;
29+
import okhttp3.ResponseBody;
30+
import okhttp3.ws.WebSocket;
31+
import okhttp3.ws.WebSocketCall;
32+
import okhttp3.ws.WebSocketListener;
3233

3334
import java.io.IOException;
3435

3536
import javax.annotation.Nonnull;
3637
import javax.annotation.Nullable;
3738

3839
import okio.Buffer;
39-
import okio.BufferedSource;
4040
import rx.Observable;
4141
import rx.Subscriber;
4242
import rx.functions.Action0;
@@ -122,19 +122,19 @@ private void returnException(IOException e) {
122122
}
123123

124124
@Override
125-
public void onMessage(BufferedSource payload, WebSocket.PayloadType type) throws IOException {
125+
public void onMessage(ResponseBody message) throws IOException {
126126
try {
127127
final WebSocket sender = webSocketOrNull();
128128
if (sender == null) {
129129
return;
130130
}
131-
if (WebSocket.PayloadType.BINARY.equals(type)) {
132-
subscriber.onNext(new RxEventBinaryMessage(sender, payload.readByteArray()));
133-
} else if (WebSocket.PayloadType.TEXT.equals(type)) {
134-
subscriber.onNext(new RxEventStringMessage(sender, payload.readUtf8()));
131+
if (WebSocket.BINARY.equals(message.contentType())) {
132+
subscriber.onNext(new RxEventBinaryMessage(sender, message.bytes()));
133+
} else if (WebSocket.TEXT.equals(message.contentType())) {
134+
subscriber.onNext(new RxEventStringMessage(sender, message.string()));
135135
}
136136
} finally {
137-
payload.close();
137+
message.close();
138138
}
139139
}
140140

websockets-rxjava/src/main/java/com/appunite/websocket/rx/messages/RxEventBinaryMessage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.appunite.websocket.rx.messages;
1818

19-
import com.squareup.okhttp.ws.WebSocket;
19+
import okhttp3.ws.WebSocket;
2020

2121
import java.util.Arrays;
2222

websockets-rxjava/src/main/java/com/appunite/websocket/rx/messages/RxEventBinaryMessageAbs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.appunite.websocket.rx.messages;
1818

19-
import com.squareup.okhttp.ws.WebSocket;
19+
import okhttp3.ws.WebSocket;
2020

2121
import javax.annotation.Nonnull;
2222

0 commit comments

Comments
 (0)