Nalee Riddell --- Javascript-II#207
Open
odax wants to merge 7 commits intobloominstituteoftechnology:masterfrom
Open
Nalee Riddell --- Javascript-II#207odax wants to merge 7 commits intobloominstituteoftechnology:masterfrom
odax wants to merge 7 commits intobloominstituteoftechnology:masterfrom
Conversation
…ot passed by the test. This is because it says that the children objects are not inheriting the GameObjects destroy funcion. This is probably caused because since the linter would not let me just have return `string` as a class method, i had to refer to at least one this. If you look at the code you will see what I mean. The this file was causing a lot of headaches in terms of linting and i couldnt figure it out. I had to comment the whole page out just to test the class and prototype files.
What Went Well:Nice job on this one. Like we discussed in our 1:1, the issues you were having were related to using es6 classes in prototype, but you clearly understood what to do to correct. Good commits as well. You were able to solve the other problems. Keep it up!Areas For Improvement:Keep pushing for those stretch goals if you can!Questions:None, nice work!Rating (1-3):2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.