Skip to content

Nalee Riddell --- Javascript-II#207

Open
odax wants to merge 7 commits intobloominstituteoftechnology:masterfrom
odax:master
Open

Nalee Riddell --- Javascript-II#207
odax wants to merge 7 commits intobloominstituteoftechnology:masterfrom
odax:master

Conversation

@odax
Copy link
Copy Markdown

@odax odax commented Mar 21, 2018

No description provided.

odax added 7 commits March 21, 2018 19:06
…ot passed by the test. This is because it says that the children objects are not inheriting the GameObjects destroy funcion. This is probably caused because since the linter would not let me just have return `string` as a class method, i had to refer to at least one this. If you look at the code you will see what I mean. The this file was causing a lot of headaches in terms of linting and i couldnt figure it out. I had to comment the whole page out just to test the class and prototype files.
@justinborek
Copy link
Copy Markdown

What Went Well:

Nice job on this one. Like we discussed in our 1:1, the issues you were having were related to using es6 classes in prototype, but you clearly understood what to do to correct. Good commits as well. You were able to solve the other problems. Keep it up!

Areas For Improvement:

Keep pushing for those stretch goals if you can!

Questions:

None, nice work!

Rating (1-3):

2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants