Open
Conversation
kiachoi
approved these changes
Mar 27, 2018
kiachoi
left a comment
kiachoi
left a comment
There was a problem hiding this comment.
Great job on this project Cruise! Everything seems to be working the way it should and love seeing your commits and console.logs. As always, if you have an questions you can always let the channel know or just DM! 😄
| *.swp | ||
| node_modules | ||
| yarn.lock | ||
| yarn-error.log |
There was a problem hiding this comment.
Thank you for putting this error log in the .gitignore file! 🙏
| } | ||
| growOlder() { | ||
| this.age++; | ||
| return this.age; |
There was a problem hiding this comment.
This can be written into one line as return ++this.age as well!
| this.dimensions = properties.dimensions; | ||
| } | ||
| destroy() { | ||
| const t = this; // tricking the linter |
| @@ -3,11 +3,42 @@ | |||
| const nFibonacci = (n) => { | |||
There was a problem hiding this comment.
The way you implemented this is very interesting! I haven't seen this kind of approach before, love the fact that you thought outside of the box with the helper function!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.