Kevin Tena [JavaScript-II]#69
Open
kevten22 wants to merge 11 commits intobloominstituteoftechnology:masterfrom
Open
Kevin Tena [JavaScript-II]#69kevten22 wants to merge 11 commits intobloominstituteoftechnology:masterfrom
kevten22 wants to merge 11 commits intobloominstituteoftechnology:masterfrom
Conversation
…rs with large shirt size
bdurb
reviewed
May 23, 2018
assignments/array-methods.js
Outdated
|
|
||
| // ==== Challenge 2: Use .map() ==== | ||
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; |
There was a problem hiding this comment.
You could have removed the let allCaps = [] here. You are re-assigning it with your function.
bdurb
reviewed
May 23, 2018
| // Now that you have used .forEach(), .map(), .filter(), and .reduce(). I want you to think of potential problems you could solve given the data set and the 5k fun run theme. Try to solve 3 unique problems using one or many of the array methods listed above. | ||
|
|
||
| // Problem 1 | ||
| // We want to know not which one of these runners is the best runner but which contributed most to the cause. Find out who contributed the most. |
There was a problem hiding this comment.
Awesome use of Map and Filter here. shows a great grasp of the material.
bdurb
reviewed
May 23, 2018
assignments/callbacks.js
Outdated
|
|
||
| function firstItem(arr, cb) { | ||
| // firstItem passes the first item of the given array to the callback function. | ||
| cb(arr); |
There was a problem hiding this comment.
this is close, but remember its asking for the first item of the array to be passed into the callback. you are passing the whole array.
|
@kevten22 thank you for the PR, and the commits. Your code looks well written. I pointed out a few things to consider, but all in all great work! |
|
@kevten22 thanks for taking action on feedback. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.