Open
Conversation
ashwins93
reviewed
Oct 17, 2018
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; | ||
| runners.map(function(item) { | ||
| allCaps.push(item.first_name.toUpperCase()); |
There was a problem hiding this comment.
It is not quite how we would use a map function. The callback to the map function should return a transformed element from the original element and the map function itself returns a new array filled with the transformed elements. This is how we would typically use it
let allCaps = runners.map(function (runner) {
return runner.first_name.toUpperCase();
});| // Problem 2 | ||
| // Add the first name, last name, and company name together. | ||
| let NameCompany = []; | ||
| runners.forEach(function(item) { |
There was a problem hiding this comment.
map may have better suited for this particular task.
| } | ||
| if(list.includes(item)) { | ||
| return cb(true); | ||
| } else cb(false); |
There was a problem hiding this comment.
The else is not necessary here as we are returning inside if clause
| // Return a function that when invoked increments and returns a counter variable. | ||
| let count = 0; | ||
|
|
||
| return () => (++count); |
There was a problem hiding this comment.
Really good use of arrow function to write terse code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.