Open
Conversation
Velsu
reviewed
May 25, 2019
Velsu
left a comment
Velsu
left a comment
There was a problem hiding this comment.
Good job on the assignment Ian. You have completed most of the exercises, altough some of them have issues that i explained in the github comments below.
Your git workflow needs improvement. Try to make more descriptive and frequent commit messages.
| // ==== Challenge 1: Use .forEach() ==== | ||
| // The event director needs both the first and last names of each runner for their running bibs. Combine both the first and last names into a new array called fullName. | ||
| let fullName = []; | ||
| let fullName = runners.map(function(item) { |
There was a problem hiding this comment.
forEach was supposed to be used here instead of map.
| let allCaps = []; | ||
| console.log(allCaps); | ||
| let allCaps = runners.map(function(item) { | ||
| return item[i].first_name.toUpperCase(); |
There was a problem hiding this comment.
No need for i which is undefined anyway.
|
|
||
| // ==== Challenge 2: Create a counter function ==== | ||
| const counter = () => { | ||
| let counterVar = 0 += x; |
There was a problem hiding this comment.
This is invalid left hand side assignment.
| function getLength(arr, cb) { | ||
| // getLength passes the length of the array into the callback. | ||
| return cb(arr.length); | ||
| getLength(item, function(arrayLength) { |
|
|
||
| function last(arr, cb) { | ||
| // last passes the last item of the array into the callback. | ||
| return cb(arr.length-1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.