Skip to content

Subra - working with Justin Mathew#276

Closed
Sy-CoDe wants to merge 4 commits intobloominstituteoftechnology:masterfrom
Sy-CoDe:master
Closed

Subra - working with Justin Mathew#276
Sy-CoDe wants to merge 4 commits intobloominstituteoftechnology:masterfrom
Sy-CoDe:master

Conversation

@Sy-CoDe
Copy link
Copy Markdown

@Sy-CoDe Sy-CoDe commented Mar 20, 2018

No description provided.

@Sy-CoDe Sy-CoDe changed the title Subra Subra - working with Justin Mathew Mar 20, 2018
@justinborek
Copy link
Copy Markdown

What Went Well:

Really solid work on this one. You nailed all the goals and almost all the stretch. Your code looks great, and you clearly get the material. You commit frequently as well. Nice job!

Areas For Improvement:

You were so close on cacheFunction.js! All you needed was to change the last line from return cb(par1) to return cache[par1]! Good work though. Also, keep pushing for slightly more descriptive commits!

Questions:

None, good going!

Rating (1-3):

3

@Sy-CoDe Sy-CoDe closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants