Fixed #8835 (friend class and non-empty constructor: Uninitialized members not reported) (cppcheck-opensource#1466)

IOBYTE · danmar · commit c966f3118325 · 2018-11-06T06:44:08.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -764,7 +764,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio
             else {
                 assignAllVar(usage);
             }
-        } else if (Token::Match(ftok, "::| %name% (") && ftok->str() != "if") {
+        } else if (Token::Match(ftok, "::| %name% (") && !Token::Match(ftok, "if|while|for")) {
             if (ftok->str() == "::")
                 ftok = ftok->next();
 
diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -145,6 +145,7 @@ class TestConstructors : public TestFixture {
         TEST_CASE(uninitVar29);
         TEST_CASE(uninitVar30); // ticket #6417
         TEST_CASE(uninitVar31); // ticket #8271
+        TEST_CASE(uninitVar32); // ticket #8835
         TEST_CASE(uninitVarEnum1);
         TEST_CASE(uninitVarEnum2); // ticket #8146
         TEST_CASE(uninitVarStream);
@@ -2426,6 +2427,39 @@ class TestConstructors : public TestFixture {
         ASSERT_EQUALS("", errout.str());
     }
 
+    void uninitVar32() { // ticket #8835
+        check("class Foo {\n"
+              "   friend class Bar;\n"
+              "   int member;\n"
+              "public:\n"
+              "   Foo()\n"
+              "   {\n"
+              "      if (1) {}\n"
+              "   }\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:5]: (warning) Member variable 'Foo::member' is not initialized in the constructor.\n", errout.str());
+        check("class Foo {\n"
+              "   friend class Bar;\n"
+              "   int member;\n"
+              "public:\n"
+              "   Foo()\n"
+              "   {\n"
+              "      while (1) {}\n"
+              "   }\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:5]: (warning) Member variable 'Foo::member' is not initialized in the constructor.\n", errout.str());
+        check("class Foo {\n"
+              "   friend class Bar;\n"
+              "   int member;\n"
+              "public:\n"
+              "   Foo()\n"
+              "   {\n"
+              "      for (;;) {}\n"
+              "   }\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:5]: (warning) Member variable 'Foo::member' is not initialized in the constructor.\n", errout.str());
+    }
+
     void uninitVarArray1() {
         check("class John\n"
               "{\n"

Original file line number	Diff line number	Diff line change
`@@ -764,7 +764,7 @@ void CheckClass::initializeVarList(const Function &func, std::list<const Functio`
`764`	`764`	`else {`
`765`	`765`	`assignAllVar(usage);`
`766`	`766`	`}`
`767`		`- } else if (Token::Match(ftok, "::\| %name% (") && ftok->str() != "if") {`
	`767`	`+ } else if (Token::Match(ftok, "::\| %name% (") && !Token::Match(ftok, "if\|while\|for")) {`
`768`	`768`	`if (ftok->str() == "::")`
`769`	`769`	`ftok = ftok->next();`
`770`	`770`