Properly dispose signalr hub connection listeners (#11514) #11537
Conversation
|
Warning Rate limit exceeded@ysmoradi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the SignalR event handler management and disposal pattern in the AppClientCoordinator component. The changes prevent potential duplicate event handler registrations and ensure proper cleanup order during component disposal.
- Adds
Remove()calls before each SignalR event handler registration to prevent duplicate subscriptions - Clears the
signalROnDisposableslist after disposing its items - Moves the
base.DisposeAsync()call to the end of the disposal method
2 participants
closes #11514