Skip to content

Commit 0ed14f5

Browse files
markjschreiberandreasprlic
authored andcommitted
Added logging and Unchecked exceptions
1 parent 69e85a2 commit 0ed14f5

2 files changed

Lines changed: 13 additions & 0 deletions

File tree

_wikis/BioJava3_Design.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,17 @@ Basic principles
5858
getTopBlastHit()).
5959
- The source code license will be the GNU Lesser General Public
6060
License (LGPL) "version 2.1 or any later version".
61+
- In general BJ3 exceptions should be RuntimeExceptions and unchecked.
62+
They should also be well documented and give useful messages. It
63+
should be up to the developer to decide what to capture and what not
64+
to. In the current BioJava there are way to many exceptions that
65+
can't really happen under any normal circumstances. We should only
66+
need to think about exceptions in exceptional circumstances.
67+
- The default Java logging API should be used extensively. This will
68+
allow a developer the ability to fine tune debugging. The core
69+
module should have a logging helper with static convenience methods
70+
to make it very easy to liberally use logging calls via static
71+
imports.
6172

6273
Compromises and Unfinished bits
6374
-------------------------------

_wikis/BioJava3_Design.mediawiki

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ This document was based on comments made on the following pages:
2525
* Always ALWAYS correctly implement equals, compareTo, hashCode, and Serializable wherever possible.
2626
* Any general-use methods to be exposed via SPI (e.g. getTopBlastHit()).
2727
* The source code license will be the GNU Lesser General Public License (LGPL) "version 2.1 or any later version".
28+
* In general BJ3 exceptions should be RuntimeExceptions and unchecked. They should also be well documented and give useful messages. It should be up to the developer to decide what to capture and what not to. In the current BioJava there are way to many exceptions that can't really happen under any normal circumstances. We should only need to think about exceptions in exceptional circumstances.
29+
* The default Java logging API should be used extensively. This will allow a developer the ability to fine tune debugging. The core module should have a logging helper with static convenience methods to make it very easy to liberally use logging calls via static imports.
2830
2931
==Compromises and Unfinished bits==
3032
* TestNG was suggested instead of JUnit, but knowledge of this tool is not so widespread and this may impact on quality of testing.

0 commit comments

Comments
 (0)