Skip to content

Commit 2b33a56

Browse files
committed
Javadoc fix: many errors in struct align package
1 parent 52d1053 commit 2b33a56

8 files changed

Lines changed: 13 additions & 24 deletions

File tree

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/MultipleAlignmentEnsemble.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,15 +147,13 @@ public interface MultipleAlignmentEnsemble extends ScoresCache {
147147
* structure.
148148
*
149149
* @return List of Matrix interatomic distance matrices.
150-
* @see #updateDistanceMatrix()
151150
*/
152151
public List<Matrix> getDistanceMatrix();
153152

154153
/**
155154
* Returns the List of MultipleAlignments in the ensemble.
156155
*
157156
* @return List of MultipleAlignment in the ensemble.
158-
* @see #setMultipleAlignments()
159157
*/
160158
public List<MultipleAlignment> getMultipleAlignments();
161159

@@ -165,7 +163,6 @@ public interface MultipleAlignmentEnsemble extends ScoresCache {
165163
* accessing an index of a List
166164
*
167165
* @return MultipleAlignment at the index in the ensemble.
168-
* @see #setMultipleAlignments()
169166
*/
170167
public MultipleAlignment getMultipleAlignment(int index);
171168

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/MultipleAlignmentEnsembleImpl.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public class MultipleAlignmentEnsembleImpl extends AbstractScoresCache
6767
/**
6868
* Default Constructor. Empty ensemble, no structures assigned.
6969
*
70-
* @return MultipleAlignmentEnsemble an empty ensemble instance.
7170
*/
7271
public MultipleAlignmentEnsembleImpl() {
7372

@@ -88,7 +87,6 @@ public MultipleAlignmentEnsembleImpl() {
8887
* @param structureIdentifiers
8988
* List of Structure names, that can be parsed by
9089
* {@link AtomCache}.
91-
* @return MultipleAlignmentEnsemble an ensemble with the structures.
9290
*/
9391
public MultipleAlignmentEnsembleImpl(
9492
List<StructureIdentifier> structureIdentifiers) {
@@ -102,7 +100,6 @@ public MultipleAlignmentEnsembleImpl(
102100
*
103101
* @param e
104102
* MultipleAlignmentEnsemble to copy.
105-
* @return MultipleAlignmentEnsemble identical copy of the input ensemble.
106103
*/
107104
public MultipleAlignmentEnsembleImpl(MultipleAlignmentEnsembleImpl e) {
108105

@@ -153,7 +150,6 @@ public MultipleAlignmentEnsembleImpl(MultipleAlignmentEnsembleImpl e) {
153150
* Atoms of the second structure
154151
* @param flexible
155152
* true if the alignment is flexible (use BlockSets)
156-
* @return MultipleAlignmentEnsemble an ensemble
157153
*/
158154
public MultipleAlignmentEnsembleImpl(AFPChain afp, Atom[] ca1, Atom[] ca2,
159155
boolean flexible) {

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/MultipleAlignmentImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public class MultipleAlignmentImpl extends AbstractScoresCache implements
5353
/**
5454
* Default Constructor. Empty alignment. No structures assigned.
5555
*
56-
* @return MultipleAlignment an empty MultipleAlignment instance.
5756
*/
5857
public MultipleAlignmentImpl() {
5958
this(new MultipleAlignmentEnsembleImpl()); // assign an empty ensemble.
@@ -65,7 +64,6 @@ public MultipleAlignmentImpl() {
6564
*
6665
* @param ensemble
6766
* parent MultipleAlignmentEnsemble.
68-
* @return MultipleAlignment an alignment instance part of an ensemble.
6967
*/
7068
public MultipleAlignmentImpl(MultipleAlignmentEnsemble ensemble) {
7169

@@ -87,7 +85,6 @@ public MultipleAlignmentImpl(MultipleAlignmentEnsemble ensemble) {
8785
*
8886
* @param ma
8987
* MultipleAlignmentImpl to copy.
90-
* @return MultipleAlignmentImpl identical copy of the alignment.
9188
*/
9289
public MultipleAlignmentImpl(MultipleAlignmentImpl ma) {
9390

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/mc/MultipleMcMain.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public class MultipleMcMain implements MultipleStructureAligner {
9191
/**
9292
* Default constructor.
9393
* Default parameters are used.
94-
* @param pairwise the pairwise structure alignment used to generate the
94+
* @param pairwiseAlgo the pairwise structure alignment used to generate the
9595
* multiple alignment seed.
9696
*/
9797
public MultipleMcMain(StructureAlignment pairwiseAlgo){
@@ -177,7 +177,7 @@ private MultipleAlignment generateSeed(List<Atom[]> atomArrays)
177177
* lowest average RMSD against all others.
178178
* The index of this structure is returned.
179179
*
180-
* @param alignments List double containing all-to-all pairwise alignments
180+
* @param afpAlignments List double containing all-to-all pairwise alignments
181181
* @return int reference index
182182
*/
183183
private static int chooseReferenceRMSD(List<List<AFPChain>> afpAlignments){
@@ -209,7 +209,7 @@ private static int chooseReferenceRMSD(List<List<AFPChain>> afpAlignments){
209209
* It uses the blocks in AFPChain as {@link Block}s in the
210210
* MultipleAlignment, so considers non-topological
211211
* alignments, if the alignment is rigid. If the alignment is flexible,
212-
* it considers the blocks as {@link BlockSets}.
212+
* it considers the blocks as {@link BlockSet}s.
213213
*
214214
* @param afpList the list of pairwise alignments to the reference
215215
* @param atomArrays List of Atoms of the structures

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/mc/MultipleMcOptimizer.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ public class MultipleMcOptimizer implements Callable<MultipleAlignment> {
108108
* the parameter beam
109109
* @param reference
110110
* the index of the most similar structure to all others
111-
* @throws StructureException
112111
*/
113112
public MultipleMcOptimizer(MultipleAlignment seedAln,
114113
MultipleMcParameters params, int reference) {
@@ -235,7 +234,7 @@ private void initialize() throws StructureException {
235234
* <li>Shrink Block: move a block column to the freePool.
236235
* <li>Insert gap: insert a gap in a random position of the alignment.
237236
* </ul>
238-
* </li>
237+
*
239238
*/
240239
public MultipleAlignment optimize() throws StructureException {
241240

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/util/MultipleAlignmentScorer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ public static double getAvgTMScore(List<Atom[]> transformed,
304304
* length.
305305
*
306306
* @param alignment
307-
* @param reference
307+
* @param ref
308308
* Index of the reference structure
309309
* @return
310310
* @throws StructureException
@@ -427,7 +427,7 @@ public static double getMCScore(MultipleAlignment alignment,
427427
* Complexity: T(n,l) = O(l*n^2), if n=number of structures and l=alignment
428428
* length.
429429
*
430-
* @param transformed
430+
* @param trans
431431
* List of transformed Atom arrays
432432
* @param d0
433433
* parameter for the half-score distance

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/util/MultipleAlignmentTools.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ public static List<String> getSequenceAlignment(
309309
* Blocks is indicated by a gap in all positions, meaning that there is a
310310
* possible discontinuity.
311311
*
312-
* @param alignment
312+
* @param msa
313313
* input MultipleAlignment
314314
* @return String for each row in the alignment, giving the 1-letter code
315315
* for each aligned residue.
@@ -466,7 +466,7 @@ else if (previousPos[str] + 1 == residue) {
466466
* gap in all positions, meaning that there is something unaligned
467467
* inbetween.
468468
*
469-
* @param alignment
469+
* @param ma
470470
* input MultipleAlignment
471471
* @return String for each row in the alignment, giving the 1-letter code
472472
* for each aligned residue.
@@ -479,7 +479,7 @@ public static List<String> getBlockSequenceAlignment(MultipleAlignment ma) {
479479
* Returns the Atom of the specified structure that is aligned in the
480480
* sequence alignment position specified.
481481
*
482-
* @param multAln
482+
* @param msa
483483
* the MultipleAlignment object from where the sequence alignment
484484
* has been generated
485485
* @param mapSeqToStruct
@@ -568,7 +568,7 @@ public static int getBlockForSequencePosition(MultipleAlignment multAln,
568568
* Complexity: T(n,l) = O(l*n^2), if n=number of structures and l=alignment
569569
* length.
570570
*
571-
* @param alignment
571+
* @param msa
572572
* MultipleAlignment
573573
* @return Matrix containing all average residue distances
574574
*/
@@ -644,7 +644,7 @@ public static Matrix getAverageResidueDistances(List<Atom[]> transformed) {
644644
* <p>
645645
* For each structure in the alignment, returns an atom for each
646646
* representative atom in the aligned columns, omitting unaligned residues
647-
* (i.e. an array of length <tt>alignment.length()</tt> ).
647+
* (i.e. an array of length <code>alignment.length()</code> ).
648648
* <p>
649649
* All blocks are concatenated together, so Atoms may not appear in the same
650650
* order as in their parent structure. If the alignment blocks contain null

biojava-structure/src/main/java/org/biojava/nbio/structure/align/multiple/util/MultipleAlignmentWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public static String toAlignedResidues(MultipleAlignment multAln) {
194194
* Converts the transformation Matrices of the alignment into a String
195195
* output.
196196
*
197-
* @param afpChain
197+
* @param alignment
198198
* @return String transformation Matrices
199199
*/
200200
public static String toTransformMatrices(MultipleAlignment alignment) {
@@ -289,7 +289,7 @@ public static String toXML(MultipleAlignmentEnsemble ensemble)
289289
* ATOM 2004 CA ARG 4 32.662 -25.111 7.172 132 ARG
290290
* ATOM 2005 CA GLY 5 29.121 -25.194 8.602 133 ARG
291291
*
292-
* Column 1 -30: Atom & Residue records of query sequence.
292+
* Column 1 -30: Atom and Residue records of query sequence.
293293
* Column 31-54: Coordinates of atoms in query copied from corresponding atoms in template.
294294
* Column 55-59: Corresponding residue number in template based on alignment
295295
* Column 60-64: Corresponding residue name in template

0 commit comments

Comments
 (0)