Merge pull request OpenHFT#26 from DevFactory/release/Utility-classes-should-not-have-public-constructors-fix-1

peter-lawrey · web-flow · commit 98bd330f6faf · 2016-07-24T10:05:17.000+01:00
squid:S1118 - Utility classes should not have public constructors
diff --git a/affinity/src/main/java/net/openhft/affinity/impl/Utilities.java b/affinity/src/main/java/net/openhft/affinity/impl/Utilities.java
@@ -7,7 +7,10 @@
 /**
  * Created by andre on 20/06/15.
  */
-public class Utilities {
+public final class Utilities {
+    private Utilities() {
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
     /**
      * Creates a hexademical representation of the bit set
      *
diff --git a/affinity/src/main/java/net/openhft/ticker/Ticker.java b/affinity/src/main/java/net/openhft/ticker/Ticker.java
@@ -35,6 +35,10 @@ public final class Ticker {
         }
     }
 
+    private Ticker() {
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
+
     /**
      * @return The current value of the system timer, in nanoseconds.
      */
diff --git a/affinity/src/test/java/net/openhft/affinity/AffinityLockBindMain.java b/affinity/src/test/java/net/openhft/affinity/AffinityLockBindMain.java
@@ -21,7 +21,11 @@
 /**
  * @author peter.lawrey
  */
-public class AffinityLockBindMain {
+public final class AffinityLockBindMain {
+    private AffinityLockBindMain() {
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
+
     public static void main(String... args) throws InterruptedException {
         AffinityLock al = AffinityLock.acquireLock();
         try {
diff --git a/affinity/src/test/java/net/openhft/affinity/AffinityLockMain.java b/affinity/src/test/java/net/openhft/affinity/AffinityLockMain.java
@@ -19,7 +19,11 @@
 /**
  * @author peter.lawrey
  */
-public class AffinityLockMain {
+public final class AffinityLockMain {
+    private AffinityLockMain() {
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
+
     public static void main(String... args) throws InterruptedException {
         AffinityLock al = AffinityLock.acquireLock();
         try {
diff --git a/affinity/src/test/java/net/openhft/affinity/AffinitySupportMain.java b/affinity/src/test/java/net/openhft/affinity/AffinitySupportMain.java
@@ -19,7 +19,11 @@
 /**
  * @author peter.lawrey
  */
-public class AffinitySupportMain {
+public final class AffinitySupportMain {
+    private AffinitySupportMain() {
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
+
     public static void main(String... args) {
         AffinityLock al = AffinityLock.acquireLock();
         try {
diff --git a/affinity/src/test/java/net/openhft/affinity/AffinityThreadFactoryMain.java b/affinity/src/test/java/net/openhft/affinity/AffinityThreadFactoryMain.java
@@ -26,10 +26,13 @@
 /**
  * @author peter.lawrey
  */
-public class AffinityThreadFactoryMain {
+public final class AffinityThreadFactoryMain {
     private static final ExecutorService ES = Executors.newFixedThreadPool(4,
             new AffinityThreadFactory("bg", SAME_CORE, DIFFERENT_SOCKET, ANY));
 
+    private AffinityThreadFactoryMain(){
+        throw new InstantiationError( "Must not instantiate this class" );
+    }
     public static void main(String... args) throws InterruptedException {
         for (int i = 0; i < 12; i++)
             ES.submit(new Callable<Void>() {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,10 @@ public final class Ticker {`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ private Ticker() {`
	`39`	`+ throw new InstantiationError( "Must not instantiate this class" );`
	`40`	`+ }`
	`41`	`+`
`38`	`42`	`/**`
`39`	`43`	`* @return The current value of the system timer, in nanoseconds.`
`40`	`44`	`*/`