Skip to content

Commit 652abe2

Browse files
Ben McCannejona86
Ben McCann
authored and
ejona86
committed
Simplify the build instructions now that Netty can be fetched from Maven
1 parent c73b75e commit 652abe2

4 files changed

Lines changed: 0 additions & 32 deletions

File tree

‎.gitmodules‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎README.md‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,16 +116,6 @@ How to Build
116116
------------
117117
This section is only necessary if you are making changes to gRPC-Java.
118118

119-
### Build Netty
120-
grpc-java requires Netty 4.1, which is still in flux. The version we need can be
121-
found in the lib/netty submodule, which requires Maven 3.2 or higher to build:
122-
```
123-
$ git submodule update --init
124-
$ cd lib/netty
125-
$ mvn install -pl codec-http2 -am -DskipTests=true
126-
```
127-
128-
### Build gRPC
129119
Building requires JDK 8, as our tests use TLS.
130120

131121
grpc-java has a C++ code generation plugin for protoc. Since many Java

‎buildscripts/make_dependencies.sh‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,3 @@ else
1717
make install
1818
popd
1919
fi
20-
21-
# Make and install netty
22-
pushd lib/netty
23-
BUILD_NETTY=1
24-
NETTY_REV_FILE="$HOME/.m2/repository/io/netty/netty-ver"
25-
REV="$(git rev-parse HEAD)"
26-
if [ -f "$NETTY_REV_FILE" ]; then
27-
REV_LAST="$(cat "$NETTY_REV_FILE")"
28-
if [ z"$REV" = z"$REV_LAST" ]; then
29-
BUILD_NETTY=0
30-
echo "Not building Netty; already at $REV"
31-
fi
32-
fi
33-
if [ $BUILD_NETTY = 1 ]; then
34-
mvn install -pl codec-http2 -am -DskipTests=true
35-
echo "$REV" > "$NETTY_REV_FILE"
36-
fi
37-
popd

‎lib/netty‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)