Use more NIO on Windows #28126
Draft
Use more NIO on Windows #28126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pure refactoring that prepares for solutions to bazelbuild#23729.
fmeum
force-pushed
the
23729-java-fs-nio
branch
3 times, most recently
from
0706f17 to
3d78a04
Compare
fmeum
force-pushed
the
23729-java-fs-nio
branch
2 times, most recently
from
753127d to
a8658ae
Compare
* Using `Files.list` in `readdir` avoids an extra stat per file.
* Use `checkAccess` directly in the `is{Readable,Writable,Executable}` methods to make it more obvious that they distinguish between failure to get the metadata and the file not being accessible. This is what `File.is*` does under the hood anyway.
Also delete an unused method and explicitly annotate `getNioPath` and `getIoFile` overrides to not return null as their base definition may.
# Conflicts: # src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
fmeum
force-pushed
the
23729-java-fs-nio
branch
5 times, most recently
from
a1a7f2e to
5e65600
Compare
fmeum
force-pushed
the
23729-java-fs-nio
branch
from
16e8258 to
76441ed
Compare
fmeum
force-pushed
the
23729-java-fs-nio
branch
from
191b2ba to
4f8c00d
Compare
fmeum
force-pushed
the
23729-java-fs-nio
branch
from
f5c87e0 to
1f32cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files.listinreaddiravoids an extra stat per file on Windows.checkAccessdirectly in theis{Readable,Writable,Executable}methods to make it more obvious that they distinguish between failure to get the metadata and the file not being accessible. This is whatFile.is*does under the hood anyway. Also ensure that non-executable parent directories are handled correctly for all methods and avoid an extra stat in case the file exists and has the queried property.setWritableavoids another stat.Related to #23729 since it removes some usages of
getIoFile().