Don't keep the journal of a PersistentMap open #28108
Open
+19
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
patch-42
branch
2 times, most recently
from
8f2d9c3 to
1c15b83
Compare
There was a problem hiding this comment.
Pull request overview
This pull request enables the RewindingTest to run on Windows by removing the "no_windows" tag. However, it also includes extensive debugging code that appears to have been used for troubleshooting but should not be merged into production.
- Removes the Windows restriction from RewindingTest in the BUILD file
- Adds multiple debug statements (printStackTrace() and System.err.println()) throughout production code
- Includes a minor whitespace fix in ExecutionTool.java
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/test/java/com/google/devtools/build/lib/skyframe/rewinding/BUILD | Removes "no_windows" tag to enable test on Windows |
| src/main/java/com/google/devtools/build/lib/util/PersistentMap.java | Adds debug printStackTrace() and System.err.println() statements that should be removed |
| src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java | Adds debug output for interrupt handling and action cache operations, plus minor formatting fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/util/PersistentMap.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/util/PersistentMap.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/util/PersistentMap.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/util/PersistentMap.java
Outdated
Show resolved
Hide resolved
fmeum
changed the title
fmeum
force-pushed
the
patch-42
branch
3 times, most recently
from
e657af4 to
ce681c4
Compare
github-actions
bot
added
the
awaiting-review
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the journal file is not kept open after a build, which has been observed to cause
RewindingTestto fail on Windows, which disallows deleting open files (in this case during test case cleanup).Since the journal is written out at most every 3 seconds for all current usages of the
PersistentMapclass, the overhead of the additionalopenis negligible.Also include small tweaks to
RewindingTestso that it can be enabled on Windows. In particular, the order ofSymlinkActionandSourceManifestActionbeing rewound doesn't seem to be fixed and can differ on Windows.