fixed passedByValue warning hidden by suppression for false positive (cppcheck-opensource#2974)

firewave · web-flow · commit 9d57b832b81a · 2020-12-24T20:09:11.000+01:00
diff --git a/cli/cppcheckexecutor.cpp b/cli/cppcheckexecutor.cpp
@@ -1170,7 +1170,7 @@ bool CppCheckExecutor::tryLoadLibrary(Library& destination, const char* basepath
  * Execute a shell command and read the output from it. Returns true if command terminated successfully.
  */
 // cppcheck-suppress passedByValue
-bool CppCheckExecutor::executeCommand(std::string exe, std::vector<std::string> args, std::string redirect, std::string *output)
+bool CppCheckExecutor::executeCommand(std::string exe, std::vector<std::string> args, const std::string &redirect, std::string *output)
 {
     output->clear();
 
diff --git a/cli/cppcheckexecutor.h b/cli/cppcheckexecutor.h
@@ -111,7 +111,7 @@ class CppCheckExecutor : public ErrorLogger {
     /**
      * Execute a shell command and read the output from it. Returns true if command terminated successfully.
      */
-    static bool executeCommand(std::string exe, std::vector<std::string> args, std::string redirect, std::string *output);
+    static bool executeCommand(std::string exe, std::vector<std::string> args, const std::string &redirect, std::string *output);
 
 protected:
 

Original file line number	Diff line number	Diff line change
`@@ -1170,7 +1170,7 @@ bool CppCheckExecutor::tryLoadLibrary(Library& destination, const char* basepath`
`1170`	`1170`	`* Execute a shell command and read the output from it. Returns true if command terminated successfully.`
`1171`	`1171`	`*/`
`1172`	`1172`	`// cppcheck-suppress passedByValue`
`1173`		`-bool CppCheckExecutor::executeCommand(std::string exe, std::vector<std::string> args, std::string redirect, std::string *output)`
	`1173`	`+bool CppCheckExecutor::executeCommand(std::string exe, std::vector<std::string> args, const std::string &redirect, std::string *output)`
`1174`	`1174`	`{`
`1175`	`1175`	`output->clear();`
`1176`	`1176`