Replace 'Collection.addAll()' with parametrized constructor call

valfirst · valfirst · commit b2b75f54d2f1 · 2018-01-15T22:36:00.000+03:00
diff --git a/src/main/java/io/appium/java_client/pagefactory/interceptors/InterceptorOfAListOfElements.java b/src/main/java/io/appium/java_client/pagefactory/interceptors/InterceptorOfAListOfElements.java
@@ -45,8 +45,7 @@ public Object intercept(Object obj, Method method, Object[] args, MethodProxy pr
             return proxy.invokeSuper(obj, args);
         }
 
-        List<WebElement> realElements = new ArrayList<>();
-        realElements.addAll(locator.findElements());
+        List<WebElement> realElements = new ArrayList<>(locator.findElements());
         return getObject(realElements, method, args);
     }
 }
diff --git a/src/test/java/io/appium/java_client/events/StubWebElement.java b/src/test/java/io/appium/java_client/events/StubWebElement.java
@@ -29,9 +29,7 @@ public class StubWebElement implements WebElement, FindsByClassName, FindsByCssS
     FindsByAndroidUIAutomator<WebElement>, FindsByIosUIAutomation<WebElement>, FindsByFluentSelector<WebElement> {
 
     private static List<WebElement> createStubSubElementList() {
-        List<WebElement> result = new ArrayList<>();
-        result.addAll(ImmutableList.of(new StubWebElement(), new StubWebElement()));
-        return result;
+        return new ArrayList<>(ImmutableList.of(new StubWebElement(), new StubWebElement()));
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,7 @@ public Object intercept(Object obj, Method method, Object[] args, MethodProxy pr`
`45`	`45`	`return proxy.invokeSuper(obj, args);`
`46`	`46`	`}`
`47`	`47`
`48`		`- List<WebElement> realElements = new ArrayList<>();`
`49`		`- realElements.addAll(locator.findElements());`
	`48`	`+ List<WebElement> realElements = new ArrayList<>(locator.findElements());`
`50`	`49`	`return getObject(realElements, method, args);`
`51`	`50`	`}`
`52`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,7 @@ public class StubWebElement implements WebElement, FindsByClassName, FindsByCssS`
`29`	`29`	`FindsByAndroidUIAutomator<WebElement>, FindsByIosUIAutomation<WebElement>, FindsByFluentSelector<WebElement> {`
`30`	`30`
`31`	`31`	`private static List<WebElement> createStubSubElementList() {`
`32`		`- List<WebElement> result = new ArrayList<>();`
`33`		`- result.addAll(ImmutableList.of(new StubWebElement(), new StubWebElement()));`
`34`		`- return result;`
	`32`	`+ return new ArrayList<>(ImmutableList.of(new StubWebElement(), new StubWebElement()));`
`35`	`33`	`}`
`36`	`34`
`37`	`35`