Skip to content

Commit 55404aa

Browse files
committed
for kubernetes-client#871 add TODO for tls verion detection
1 parent 3989b6b commit 55404aa

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

util/src/main/java/io/kubernetes/client/util/authenticators/OpenIDConnectAuthenticator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import java.util.Scanner;
3434
import javax.net.ssl.HttpsURLConnection;
3535
import javax.net.ssl.SSLContext;
36+
import javax.net.ssl.SSLEngine;
3637
import javax.net.ssl.TrustManagerFactory;
3738
import org.jose4j.json.internal.json_simple.JSONObject;
3839
import org.jose4j.json.internal.json_simple.parser.JSONParser;
@@ -139,6 +140,8 @@ public Map<String, Object> refresh(Map<String, Object> config) {
139140
TrustManagerFactory tmf = TrustManagerFactory.getInstance("PKIX");
140141
tmf.init(ks);
141142

143+
// TODO would be good to make this more dyanamic. Doesn't seem like
144+
// a good way to do this.
142145
sslContext = SSLContext.getInstance("TLSv1.2");
143146
sslContext.init(null, tmf.getTrustManagers(), new SecureRandom());
144147

0 commit comments

Comments
 (0)