Remove unneeded getConfig since config is already public variable.

Matt Mazzola · Matt Mazzola · commit 7e847e8e8eb2 · 2016-06-27T14:10:24.000-07:00
diff --git a/src/embed.ts b/src/embed.ts
@@ -85,10 +85,6 @@ export abstract class Embed {
         this.hpm = hpmFactory(this.iframe.contentWindow, this.service.wpmp);
     }
 
-    getConfig(): IInternalEmbedConfiguration {
-        return this.config;
-    }
-
     /**
      * Handler for when the iframe has finished loading the powerbi placeholder page.
      * This is used to inject configuration data such as id, access token, and settings etc
diff --git a/src/service.ts b/src/service.ts
@@ -186,6 +186,9 @@ export class Service {
         return component;
     }
     
+    /**
+     * Given and element which arleady contains embed, load with new configuration
+     */
     private embedExisting(element: IPowerBiElement, config: embed.IEmbedConfiguration): embed.Embed {
         const component = utils.find(x => x.element === element, this.embeds);
         if (!component) {
@@ -249,9 +252,8 @@ export class Service {
 
     handleEvent(event: IEvent<any>): void {
         const embed = utils.find(embed => {
-            const config = embed.getConfig();
-            return (config.type === event.type
-                && config.uniqueId === event.id);
+            return (embed.config.type === event.type
+                && embed.config.uniqueId === event.id);
         }, this.embeds);
 
         if(embed) {
diff --git a/test/test.spec.ts b/test/test.spec.ts
@@ -283,7 +283,7 @@ describe('service', function () {
 
       // Assert
       var report = powerbi.get($reportContainer[0]);
-      var accessToken = report.getConfig().accessToken;
+      var accessToken = report.config.accessToken;
 
       expect(accessToken).toEqual(testToken);
 
@@ -343,7 +343,7 @@ describe('service', function () {
         const report = powerbi.embed($reportContainer[0], { id: testReportId });
 
         // Assert
-        expect(report.getConfig().id).toEqual(testReportId);
+        expect(report.config.id).toEqual(testReportId);
       });
 
       it('should fallback to using id from attribute if not supplied in embed/load configuration', function () {
@@ -357,7 +357,7 @@ describe('service', function () {
         const report = powerbi.embed($reportContainer[0]);
 
         // Assert
-        expect(report.getConfig().id).toEqual(testReportId);
+        expect(report.config.id).toEqual(testReportId);
       });
 
       it('should fallback to using id from embedUrl if not supplied in embed/load configuration or attribute', function () {
@@ -371,7 +371,7 @@ describe('service', function () {
         const report = powerbi.embed($reportContainer[0]);
 
         // Assert
-        expect(report.getConfig().id).toEqual(testReportId);
+        expect(report.config.id).toEqual(testReportId);
       });
     });
 
@@ -2484,7 +2484,7 @@ describe('SDK-to-HPM', function () {
       embedUrl: iframeSrc
     };
     report = <report.Report>powerbi.embed($element[0], embedConfiguration);
-    uniqueId = report.getConfig().uniqueId;
+    uniqueId = report.config.uniqueId;
 
     iframe = <HTMLIFrameElement>$element.find('iframe')[0];
 
@@ -3339,7 +3339,7 @@ describe('SDK-to-WPMP', function () {
       wpmpName: 'SDK-to-WPMP report wpmp'
     };
     report = <report.Report>powerbi.embed($element[0], embedConfiguration);
-    uniqueId = report.getConfig().uniqueId;
+    uniqueId = report.config.uniqueId;
 
     iframe = <HTMLIFrameElement>$element.find('iframe')[0];
 
@@ -4307,7 +4307,7 @@ describe('SDK-to-MockApp', function () {
       report2.on(testData.eventName, testData.handler2);
 
       // Act
-      iframeHpm.post(`/reports/${report2.getConfig().uniqueId}/events/${testData.eventName}`, testData.simulatedPageChangeBody)
+      iframeHpm.post(`/reports/${report2.config.uniqueId}/events/${testData.eventName}`, testData.simulatedPageChangeBody)
         .then(response => {
           // Assert
           expect(testData.handler2).toHaveBeenCalledWith(testData.simulatedPageChangeBody);
