Merged
Conversation
Collaborator
|
The tests in impl/analyzer could just live in core_test like the others |
Contributor
Author
|
Got it. I moved the valid case and removed the other two (redundant). |
Contributor
Author
|
I added a loop test for your case in #834 as well (and a reference to the issue in the PR description). |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
Addressing #834 and #1950, this fixes invalid
recurarity handling.SCI was accepting malformed
recurcalls in functions, especially variadic ones like(fn [f & args] ...), where(recur r)should be rejected becauserecurmust supply values for bothfandargsThis change adds the missing arity validation in the analyzer so SCI now matches Clojure and fails fast with
Mismatched argument count to recurIn this PR I'm also adding regression coverage for invalid fixed-arity and variadic
recurcalls, plus a positive trampoline-style case (took from the issue creator).