feat(http): add setDataCallback for streaming data support #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add HttpDataCallback type for handling incoming data chunks
- Implement setDataCallback method in HttpRequest class
- When data callback is set, response data is not accumulated in _responseData
- Enable progressive data processing for large file downloads and streaming
- Maintain backward compatibility - existing code continues to work unchanged
This allows:
- Memory-efficient handling of large responses
- Real-time processing of data streams
- Progress tracking during downloads
- Custom data storage strategies
Usage:
request->setDataCallback([](HttpResponse* response, const char* data, size_t size) {
// Process data chunks as they arrive
fwrite(data, 1, size, outputFile);
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows:
Usage:
request->setDataCallback([](HttpResponse* response, const char* data, size_t size) {
// Process data chunks as they arrive
fwrite(data, 1, size, outputFile);
});
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR