-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(diff): properties from ChangeSet diff were ignored #30093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| /** | ||
| * Compare two CloudFormation resources and return semantic differences between them | ||
| */ | ||
| export function diffResource(oldValue: types.Resource, newValue: types.Resource): types.ResourceDifference { | ||
| return impl.diffResource(oldValue, newValue); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never used, so I removed it
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
It's awesome to get this fixed. Thank you for this PR! 🏆 |
) Reverts: [30093](#30093)
Fixes # [30093](aws/aws-cdk#30093)
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes aws/aws-cdk-cli#641
Reason for this change
Description of changes
Description of how you validated changes
cdk diff:Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license