ADAP-186 - Add support for passing a url to embed.bat (openfin#34)

johnman · web-flow · commit 135e479112e9 · 2020-01-30T11:22:50.000-05:00
* ADAP-185 - Update Batch Scripts to point to latest jar files

* ADAP-186 - Add support for passing a url to embed.bat in order to load a custom url into the sample app. Update Readme.md
diff --git a/README.md b/README.md
@@ -94,12 +94,14 @@ Source code for the example is located in /src/main/java/com/openfin/desktop/dem
 
 1. Clone this repository
 
-2. Go to release directory and start embed.bat
+2. Go to release directory and start embed.bat ( the default embedded url is https://openfin.co. Pass the url you wish to load if you want something different e.g. embed.bat https://www.mydomain.com )
 
-3. Once the java app starts, click on "Launch OpenFin" button, which should start OpenFin Runtime and embed the OpenFin application that points to https://openfin.co
+3. Once the java app starts, click on "Launch OpenFin" button, which should start OpenFin Runtime and embed the OpenFin application that points to https://openfin.co (or your custom url if you specified one)
 
 4. Click "Shutdown OpenFin" button to close HTML5 application and the Java Swing window
 
+If there is a problem rendering the url please check your windows display settings to see ensure scaling is set to 100%.
+
 ## Source Code Review for embedded OpenFin application
 
 Source code for the example is located in /src/main/java/com/openfin/desktop/demo/WindowEmbedDemo.java
diff --git a/release/embed.bat b/release/embed.bat
@@ -1 +1,5 @@
-java -cp openfin-desktop-java-example-7.1.1.jar;openfin-desktop-java-adapter-7.1.2.jar;TableLayout-20050920.jar;jna-4.5.1.jar;jna-platform-4.5.1.jar;json-20140107.jar;slf4j-api-1.7.5.jar;slf4j-jdk14-1.6.1.jar;websocket-api-9.3.12.v20160915.jar;websocket-client-9.3.12.v20160915.jar;websocket-common-9.3.12.v20160915.jar;jetty-io-9.3.12.v20160915.jar;jetty-util-9.3.12.v20160915.jar -Djava.util.logging.config.file=logging.properties -Dcom.openfin.demo.embed.URL=https://openfin.co -Dcom.openfin.demo.version=stable com.openfin.desktop.demo.WindowEmbedDemo
+@ECHO OFF
+set url=%1 
+IF "%~1" == "" set url=https://openfin.co
+echo Embedded url set to: %url%
+java -cp openfin-desktop-java-example-7.1.1.jar;openfin-desktop-java-adapter-7.1.2.jar;TableLayout-20050920.jar;jna-4.5.1.jar;jna-platform-4.5.1.jar;json-20140107.jar;slf4j-api-1.7.5.jar;slf4j-jdk14-1.6.1.jar;websocket-api-9.3.12.v20160915.jar;websocket-client-9.3.12.v20160915.jar;websocket-common-9.3.12.v20160915.jar;jetty-io-9.3.12.v20160915.jar;jetty-util-9.3.12.v20160915.jar -Djava.util.logging.config.file=logging.properties -Dcom.openfin.demo.embed.URL=%URL% -Dcom.openfin.demo.version=stable com.openfin.desktop.demo.WindowEmbedDemo
