Skip to content

Conversation

@siteshwar
Copy link
Contributor

This is a pull request to test style checker in SAST scans. It should not be merged.

... OpenScanHub configurations.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Copy link
Contributor Author

Test was successful. The reverted commit shows up as a new finding in https://openscanhub.fedoraproject.org/task/9999/log/added.html

@siteshwar
Copy link
Contributor Author

I am closing this pull request, but upstream maintainers may want to cherry pick 912a983.

CC @evverx

@siteshwar siteshwar closed this Sep 9, 2024
@evverx
Copy link
Collaborator

evverx commented Sep 9, 2024

Thanks! I'll reopen it and add the "dont-merge" and "CI" labels so as not to forget about this.

@evverx evverx reopened this Sep 9, 2024
@evverx evverx added CI continuous integration or tests do not merge labels Sep 9, 2024
evverx pushed a commit to evverx/avahi that referenced this pull request Sep 9, 2024
Signed-off-by: Siteshwar Vashisht <[email protected]>

It's prompted by 8e77303,
32fba39 and
16b6397 and should help to catch issues
like that automatically.

See avahi#641.
@evverx
Copy link
Collaborator

evverx commented Sep 9, 2024

Looks like I can't update this PR with my fine-grained token (because it can't have access to the fork). Instead of generating new tokens I opened #642 where I cherry-picked the second commit. I'll merge it once the CI is green. Thanks again!

@evverx evverx closed this Sep 9, 2024
evverx pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Siteshwar Vashisht <[email protected]>

It's prompted by 8e77303,
32fba39 and
16b6397 and should help to catch issues
like that automatically.

See #641.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration or tests do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants