feat: Forward extra kwargs (expires_in, issued_at) through ClientSecretJWT and PrivateKeyJWT#890
Open
liudonggalaxy wants to merge 1 commit into
Conversation
…etJWT and PrivateKeyJWT
07a0cc1 to
6b86cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a feature implementation
ClientSecretJWTandPrivateKeyJWTaccepttoken_endpoint, claims, headers, and alg, but there is no way to controlexpires_inorissued_atfor the generated JWT assertion. The underlyingsign_jwt_bearer_assertionalready supports these parameters, but they were not forwarded from the high-level classes.Before:
Solution: Accept
**kwargsin__init__(...)and forward them throughsign()toclient_secret_jwt_sign/private_key_jwt_sign, which already pass**kwargstosign_jwt_bearer_assertion.After:
Fully backward compatible. No existing parameters changed. The kwargs only captures additional keyword arguments.
Checklist
prek.pragma: no cover