Skip to content

Use variable name when generating mutations #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atulmy merged 1 commit into from
Jan 8, 2022
Merged

Use variable name when generating mutations #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/adapters/DefaultMutationAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,6 @@ export default class DefaultMutationAdapter implements IMutationAdapter {
content.join("\n ")
);
}
// Convert object to name and argument map. eg: (id: $id)
private queryDataNameAndArgumentMap() {
return this.variables && Object.keys(this.variables).length
? `(${Object.keys(this.variables).reduce(
(dataString, key, i) =>
`${dataString}${i !== 0 ? ", " : ""}${key}: $${key}`,
""
)})`
: "";
}

private queryDataArgumentAndTypeMap(variablesUsed: any): string {
if (this.fields && typeof this.fields === "object") {
Expand Down Expand Up @@ -89,7 +79,7 @@ export default class DefaultMutationAdapter implements IMutationAdapter {
}

private operationTemplate(operation: string) {
return `${operation} ${this.queryDataNameAndArgumentMap()} ${
return `${operation} ${Utils.queryDataNameAndArgumentMap(this.variables)} ${
this.fields && this.fields.length > 0
? `{
${Utils.queryFieldsMap(this.fields)}
Expand Down
42 changes: 42 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,48 @@ describe("Mutation", () => {
});
});

test("generates multiple mutations with named variables", () => {
const query = queryBuilder.mutation([
{
operation: "delete0: deleteUser",
variables: {
id0: {
name: "id",
type: "ID",
value: "user_1234",
},
},
fields: ["id"],
},
{
operation: "delete1: deleteUser",
variables: {
id1: {
name: "id",
type: "ID",
value: "user_5678",
},
},
fields: ["id"],
},
]);

expect(query).toEqual({
query: `mutation ($id0: ID, $id1: ID) {
delete0: deleteUser (id: $id0) {
id
}
delete1: deleteUser (id: $id1) {
id
}
}`,
variables: {
id0: "user_1234",
id1: "user_5678",
},
});
});

test("generates mutation with required variables", () => {
const query = queryBuilder.mutation({
operation: "userSignup",
Expand Down