Fix JsCallbackExecutor execute args#2056
Merged
Conversation
mvorisek
changed the title
mvorisek
force-pushed
the
fix_jscallbackexecutor_args
branch
11 times, most recently
from
17fc193 to
3296623
Compare
mvorisek
force-pushed
the
fix_jscallbackexecutor_args
branch
2 times, most recently
from
ac4dabe to
5390984
Compare
mvorisek
force-pushed
the
fix_jscallbackexecutor_args
branch
from
5390984 to
1272c5b
Compare
mvorisek
force-pushed
the
fix_jscallbackexecutor_args
branch
from
82ebcd7 to
d1240cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was wrongly coded since ethernity (
JsCallbackExecutor::executeModelActiondoes not accept args, args are defined by UA args) and since #1980 (d2bfed8) a functional error was implied.