Conversation
mvorisek
force-pushed
the
test_late_output_error
branch
5 times, most recently
from
3880550 to
a09e6f4
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
2 times, most recently
from
ca016a5 to
9175df5
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
2 times, most recently
from
83776ec to
415bbb2
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
from
f724432 to
fc49235
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
2 times, most recently
from
e8030a8 to
e4dd727
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
3 times, most recently
from
bfe2ad6 to
3dbd824
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
from
938ed67 to
8218bfd
Compare
mvorisek
force-pushed
the
test_late_output_error
branch
from
f4027ef to
64be949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #1706 , originally authored by @abbadon1334
I belive php instance state cannot be reverted after some late error tests, eg. the side effects of unamanged headers/output sent can be tested with HTTP tests only.
Also fixes 500 status code when unmanaged output/headers are flushed by an user manually.